hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21912) Implement BlacklistingLlapMetricsListener
Date Thu, 04 Jul 2019 08:59:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21912?focusedWorklogId=272065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-272065
]

ASF GitHub Bot logged work on HIVE-21912:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jul/19 08:58
            Start Date: 04/Jul/19 08:58
    Worklog Time Spent: 10m 
      Work Description: pvary commented on pull request #698: HIVE-21912: Implement DisablingDaemonStatisticsHandler
URL: https://github.com/apache/hive/pull/698#discussion_r300299243
 
 

 ##########
 File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapManagementProtocolClientImplFactory.java
 ##########
 @@ -0,0 +1,55 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.llap.tezplugins.metrics;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hive.llap.impl.LlapManagementProtocolClientImpl;
+import org.apache.hadoop.hive.llap.registry.LlapServiceInstance;
+import org.apache.hadoop.io.retry.RetryPolicies;
+import org.apache.hadoop.io.retry.RetryPolicy;
+import org.apache.hadoop.net.NetUtils;
+
+import javax.net.SocketFactory;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Creates a LlapManagementProtocolClientImpl from a given LlapServiceInstance.
+ */
+public class LlapManagementProtocolClientImplFactory {
+  private final Configuration conf;
+  private final RetryPolicy retryPolicy;
+  private final SocketFactory socketFactory;
+
+  public LlapManagementProtocolClientImplFactory(Configuration conf, RetryPolicy retryPolicy,
+                                                 SocketFactory socketFactory) {
+    this.conf = conf;
+    this.retryPolicy = retryPolicy;
+    this.socketFactory = socketFactory;
+  }
+
+  public static LlapManagementProtocolClientImplFactory basicInstance(Configuration conf)
{
+    return new LlapManagementProtocolClientImplFactory(
+        conf,
+        RetryPolicies.retryUpToMaximumCountWithFixedSleep(5, 3000L, TimeUnit.MILLISECONDS),
+        NetUtils.getDefaultSocketFactory(conf));
+  }
+
+  public LlapManagementProtocolClientImpl create(LlapServiceInstance serviceInstance) {
+    LlapManagementProtocolClientImpl client = new LlapManagementProtocolClientImpl(conf,
serviceInstance.getHost(),
 
 Review comment:
   Honestly? Just refactored the class without change, but good point.
   Fixed
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 272065)
    Time Spent: 3h 40m  (was: 3.5h)

> Implement BlacklistingLlapMetricsListener
> -----------------------------------------
>
>                 Key: HIVE-21912
>                 URL: https://issues.apache.org/jira/browse/HIVE-21912
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap, Tez
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21912.patch, HIVE-21912.wip-2.patch, HIVE-21912.wip.patch
>
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> We should implement a DaemonStatisticsHandler which:
>  * If a node average response time is bigger than 150% (configurable) of the other nodes
>  * If the other nodes has enough empty executors to handle the requests
> Then disables the limping node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message