hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21225) ACID: getAcidState() should cache a recursive dir listing locally
Date Mon, 15 Jul 2019 02:28:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884814#comment-16884814
] 

Hive QA commented on HIVE-21225:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 49s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 17s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 22s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 38s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 10s{color} | {color:blue}
ql in master has 2253 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 29s{color} | {color:blue}
hcatalog/streaming in master has 11 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 27s{color} | {color:blue}
streaming in master has 2 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 39s{color} | {color:blue}
itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 50s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 26s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 51s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 24s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 24s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 51s{color} | {color:red}
ql: The patch generated 33 new + 1419 unchanged - 7 fixed = 1452 total (was 1426) {color}
|
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 12s{color} | {color:red}
hcatalog/streaming: The patch generated 1 new + 229 unchanged - 0 fixed = 230 total (was 229)
{color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 15s{color} | {color:red}
streaming: The patch generated 3 new + 454 unchanged - 0 fixed = 457 total (was 454) {color}
|
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 45 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 12s{color} | {color:red}
ql generated 1 new + 2253 unchanged - 0 fixed = 2254 total (was 2253) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  1m  0s{color} | {color:red}
ql generated 2 new + 98 unchanged - 2 fixed = 100 total (was 100) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 13s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 37m 16s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Field only ever set to null:null: org.apache.hadoop.hive.ql.io.AcidUtils$HdfsDirSnapshotImpl.fileId
 In AcidUtils.java |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18026/dev-support/hive-personality.sh
|
| git revision | master / a669ca4 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18026/yetus/diff-checkstyle-ql.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18026/yetus/diff-checkstyle-hcatalog_streaming.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18026/yetus/diff-checkstyle-streaming.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-18026/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-18026/yetus/new-findbugs-ql.html
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-18026/yetus/diff-javadoc-javadoc-ql.txt
|
| modules | C: ql hcatalog/streaming streaming itests/hive-unit U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18026/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> ACID: getAcidState() should cache a recursive dir listing locally
> -----------------------------------------------------------------
>
>                 Key: HIVE-21225
>                 URL: https://issues.apache.org/jira/browse/HIVE-21225
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>            Reporter: Gopal V
>            Assignee: Vaibhav Gumashta
>            Priority: Major
>         Attachments: HIVE-21225.1.patch, HIVE-21225.10.patch, HIVE-21225.11.patch, HIVE-21225.12.patch,
HIVE-21225.2.patch, HIVE-21225.3.patch, HIVE-21225.4.patch, HIVE-21225.4.patch, HIVE-21225.5.patch,
HIVE-21225.6.patch, HIVE-21225.7.patch, HIVE-21225.7.patch, HIVE-21225.8.patch, HIVE-21225.9.patch,
async-pid-44-2.svg
>
>
> Currently getAcidState() makes 3 calls into the FS api which could be answered by making
a single recursive listDir call and reusing the same data to check for isRawFormat() and isValidBase().
> All delta operations for a single partition can go against a single listed directory
snapshot instead of interacting with the NameNode or ObjectStore within the inner loop.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message