From issues-return-161295-archive-asf-public=cust-asf.ponee.io@hive.apache.org Tue Jun 25 11:07:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2856B18062F for ; Tue, 25 Jun 2019 13:07:03 +0200 (CEST) Received: (qmail 34881 invoked by uid 500); 25 Jun 2019 11:07:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 34872 invoked by uid 99); 25 Jun 2019 11:07:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jun 2019 11:07:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D4A0BE2CC8 for ; Tue, 25 Jun 2019 11:07:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AE1022581F for ; Tue, 25 Jun 2019 11:07:00 +0000 (UTC) Date: Tue, 25 Jun 2019 11:07:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HIVE-21907) Add a new LlapDaemon Management API method to set the daemon capacity MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21907?focusedWorklogId=266541&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-266541 ] ASF GitHub Bot logged work on HIVE-21907: ----------------------------------------- Author: ASF GitHub Bot Created on: 25/Jun/19 11:06 Start Date: 25/Jun/19 11:06 Worklog Time Spent: 10m Work Description: pvary commented on pull request #685: HIVE-21907: Add a new LlapDaemon Management API method to set the daemon capacity URL: https://github.com/apache/hive/pull/685#discussion_r297131670 ########## File path: llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java ########## @@ -176,6 +181,31 @@ public TaskExecutorService(int numExecutors, int waitQueueSize, Futures.addCallback(future, new WaitQueueWorkerCallback()); } + /** + * Sets the TaskExecutorService capacity to the new values. Both the number of executors and the + * queue size should be smaller than that original values, so we do not mess up with the other Review comment: Container memory sizes are calculated based on the executors. Adding more executors and this way executing more containers can result in memory oversubscription. Added more specific comment ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 266541) Time Spent: 1h (was: 50m) > Add a new LlapDaemon Management API method to set the daemon capacity > --------------------------------------------------------------------- > > Key: HIVE-21907 > URL: https://issues.apache.org/jira/browse/HIVE-21907 > Project: Hive > Issue Type: Sub-task > Components: llap > Reporter: Peter Vary > Assignee: Peter Vary > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21907.2.patch, HIVE-21907.patch > > Time Spent: 1h > Remaining Estimate: 0h > > Add a new method to LlapManagementProtocol API which can disable an Llap node. > It would be even better, if we can dynamically set the number of executors and the size of the wait queue. This way we can disable the node setting them to 0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)