From issues-return-161354-archive-asf-public=cust-asf.ponee.io@hive.apache.org Tue Jun 25 21:29:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id ACFA418072F for ; Tue, 25 Jun 2019 23:29:01 +0200 (CEST) Received: (qmail 48794 invoked by uid 500); 25 Jun 2019 21:29:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 48761 invoked by uid 99); 25 Jun 2019 21:29:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jun 2019 21:29:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7F856E2E23 for ; Tue, 25 Jun 2019 21:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4035925816 for ; Tue, 25 Jun 2019 21:29:00 +0000 (UTC) Date: Tue, 25 Jun 2019 21:29:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HIVE-21867) Sort semijoin conditions to accelerate query processing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21867?focusedWorklogId=267052&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-267052 ] ASF GitHub Bot logged work on HIVE-21867: ----------------------------------------- Author: ASF GitHub Bot Created on: 25/Jun/19 21:28 Start Date: 25/Jun/19 21:28 Worklog Time Spent: 10m Work Description: vineetgarg02 commented on pull request #687: HIVE-21867 URL: https://github.com/apache/hive/pull/687#discussion_r297401189 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java ########## @@ -1766,6 +1774,59 @@ private void removeSemijoinOptimizationByBenefit(OptimizeTezProcContext procCtx) GenTezUtils.removeBranch(rs); GenTezUtils.removeSemiJoinOperator(procCtx.parseContext, rs, ts); } + + for (Entry> e : globalReductionFactorMap.asMap().entrySet()) { Review comment: Creating separate method for this and adding comments to explain why we are doing it will be nice. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 267052) Time Spent: 40m (was: 0.5h) > Sort semijoin conditions to accelerate query processing > ------------------------------------------------------- > > Key: HIVE-21867 > URL: https://issues.apache.org/jira/browse/HIVE-21867 > Project: Hive > Issue Type: New Feature > Components: Physical Optimizer > Reporter: Jesus Camacho Rodriguez > Assignee: Jesus Camacho Rodriguez > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21867.02.patch, HIVE-21867.03.patch, HIVE-21867.patch > > Time Spent: 40m > Remaining Estimate: 0h > > The problem was tackled for CBO in HIVE-21857. Semijoin filters are introduced later in the planning phase. Follow similar approach to sort them, trying to accelerate filter evaluation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)