From issues-return-160190-archive-asf-public=cust-asf.ponee.io@hive.apache.org Thu Jun 13 19:20:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C428E18067E for ; Thu, 13 Jun 2019 21:20:01 +0200 (CEST) Received: (qmail 3240 invoked by uid 500); 13 Jun 2019 19:20:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 3202 invoked by uid 99); 13 Jun 2019 19:20:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jun 2019 19:20:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B1655E2D7C for ; Thu, 13 Jun 2019 19:20:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 42CE22463B for ; Thu, 13 Jun 2019 19:20:00 +0000 (UTC) Date: Thu, 13 Jun 2019 19:20:00 +0000 (UTC) From: "Miklos Gergely (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-21830) Break up DDLTask - extract rest of the Alter Table operations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21830?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely updated HIVE-21830: ---------------------------------- Attachment: HIVE-21830.07.patch > Break up DDLTask - extract rest of the Alter Table operations > ------------------------------------------------------------- > > Key: HIVE-21830 > URL: https://issues.apache.org/jira/browse/HIVE-21830 > Project: Hive > Issue Type: Sub-task > Components: Hive > Affects Versions: 3.1.1 > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Labels: refactor-ddl > Fix For: 4.0.0 > > Attachments: HIVE-21830.01.patch, HIVE-21830.02.patch, HIVE-21830= .03.patch, HIVE-21830.04.patch, HIVE-21830.05.patch, HIVE-21830.06.patch, H= IVE-21830.07.patch > > > DDLTask is a huge class, more than 5000 lines long. The related DDLWork i= s also a huge class, which has a field for each=C2=A0DDL=C2=A0operation it = supports. The goal is to refactor these in order to have everything cut int= o more handleable classes under the package=C2=A0 org.apache.hadoop.hive.ql= .exec.ddl: > * have a separate class for each operation > * have a package for each operation group (database ddl, table ddl, etc)= , so the amount of classes under a package is more manageable > * make all the requests (DDLDesc subclasses) immutable > * DDLTask should be agnostic to the actual operations > * right now let's ignore the issue of having some operations handled by = DDLTask which are not actual DDL operations (lock, unlock, desc...) > In the interim time when there are two DDLTask and DDLWork classes in the= code base the new ones in the new package are called DDLTask2 and DDLWork2= thus avoiding the usage of fully qualified class names where both the old = and the new classes are in use. > Step #10: extract=C2=A0the alter table operations that left=C2=A0from the= old DDLTask, and move them under the new packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005)