hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21910) Multiple target location generation in HostAffinitySplitLocationProvider
Date Thu, 27 Jun 2019 18:14:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21910?focusedWorklogId=268708&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268708
]

ASF GitHub Bot logged work on HIVE-21910:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jun/19 18:13
            Start Date: 27/Jun/19 18:13
    Worklog Time Spent: 10m 
      Work Description: odraese commented on pull request #690: HIVE-21910: Multiple target
location generation in HostAffinitySplitLocationProvider
URL: https://github.com/apache/hive/pull/690#discussion_r298300222
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HostAffinitySplitLocationProvider.java
 ##########
 @@ -52,13 +52,19 @@
 
   private final List<String> locations;
   private final Set<String> locationSet;
+  private final int numberOfLocations;
 
-  public HostAffinitySplitLocationProvider(List<String> knownLocations) {
+  public HostAffinitySplitLocationProvider(List<String> knownLocations, int numberOfLocations)
{
     Preconditions.checkState(knownLocations != null && !knownLocations.isEmpty(),
         HostAffinitySplitLocationProvider.class.getName() +
             " needs at least 1 location to function");
+    Preconditions.checkArgument(numberOfLocations >= 0,
 
 Review comment:
   Why can numberOfLocations be zero. I would expect that the minimum is one?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 268708)
    Time Spent: 40m  (was: 0.5h)

> Multiple target location generation in HostAffinitySplitLocationProvider
> ------------------------------------------------------------------------
>
>                 Key: HIVE-21910
>                 URL: https://issues.apache.org/jira/browse/HIVE-21910
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21910.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> We need to generate multiple target locations by HostAffinitySplitLocationProvider,
so we will have deterministic fallback nodes in case the target node is disabled



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message