hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21907) Add a new LlapDaemon Management API method to set the daemon capacity
Date Mon, 24 Jun 2019 15:57:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21907?focusedWorklogId=265773&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-265773
]

ASF GitHub Bot logged work on HIVE-21907:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jun/19 15:56
            Start Date: 24/Jun/19 15:56
    Worklog Time Spent: 10m 
      Work Description: odraese commented on pull request #685: HIVE-21907: Add a new LlapDaemon
Management API method to set the daemon capacity
URL: https://github.com/apache/hive/pull/685#discussion_r296793765
 
 

 ##########
 File path: llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
 ##########
 @@ -176,6 +181,31 @@ public TaskExecutorService(int numExecutors, int waitQueueSize,
     Futures.addCallback(future, new WaitQueueWorkerCallback());
   }
 
+  /**
+   * Sets the TaskExecutorService capacity to the new values. Both the number of executors
and the
+   * queue size should be smaller than that original values, so we do not mess up with the
other
+   * settings. Setting smaller capacity will not cancel or reject already executing or queued
tasks
+   * in itself.
+   * @param newNumExecutors The new number of executors
+   * @param newWaitQueueSize The new number of wait queue size
+   */
+  @Override
+  public synchronized void setCapacity(int newNumExecutors, int newWaitQueueSize) {
+    if (newNumExecutors > configuredMaxExecutors) {
 
 Review comment:
   Should we also verify that the new values are >= zero?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 265773)
    Time Spent: 0.5h  (was: 20m)

> Add a new LlapDaemon Management API method to set the daemon capacity
> ---------------------------------------------------------------------
>
>                 Key: HIVE-21907
>                 URL: https://issues.apache.org/jira/browse/HIVE-21907
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21907.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Add a new method to LlapManagementProtocol API which can disable an Llap node.
> It would be even better, if we can dynamically set the number of executors and the size
of the wait queue. This way we can disable the node setting them to 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message