hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21844) HMS schema Upgrade Script is failing with NPE
Date Mon, 10 Jun 2019 05:15:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21844?focusedWorklogId=256634&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-256634
]

ASF GitHub Bot logged work on HIVE-21844:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jun/19 05:14
            Start Date: 10/Jun/19 05:14
    Worklog Time Spent: 10m 
      Work Description: sankarh commented on pull request #667: HIVE-21844 : HMS schema Upgrade
Script is failing with NPE
URL: https://github.com/apache/hive/pull/667#discussion_r291881418
 
 

 ##########
 File path: beeline/src/java/org/apache/hive/beeline/TableOutputFormat.java
 ##########
 @@ -116,6 +116,10 @@ ColorBuffer getOutputString(Rows rows, Rows.Row row, String delim) {
       if (buf.getVisibleLength() > 0) {
         buf.green(delim);
       }
+ 
+      if (row.values[i] == null) {
 
 Review comment:
   In apache/master, we have "SELECT 'Upgrading MetaStore schema from 2.1.0 to 2.2.0' AS MESSAGE;"
which shouldn't have the issue as per description in jira.
   I think, skipping the row based on null values is incorrect as it may have any other side
effect.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 256634)
    Time Spent: 20m  (was: 10m)

> HMS schema Upgrade Script is failing with NPE
> ---------------------------------------------
>
>                 Key: HIVE-21844
>                 URL: https://issues.apache.org/jira/browse/HIVE-21844
>             Project: Hive
>          Issue Type: Task
>          Components: HiveServer2
>    Affects Versions: 4.0.0
>            Reporter: mahesh kumar behera
>            Assignee: mahesh kumar behera
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21844.01.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> schema upgrade tool is failing with NPE while executing "SELECT 'Upgrading MetaStore
schema from 1.2.0 to 2.0.0' AS ' '". The header row (metadata) is coming with rows having
value null. This is causing null pointer access in function TableOutputFormat::getOutputString
when row.values[i] is accessed. Instead of " AS ' ' ", if some other value  like "AS dummy"
is given, it's working fine. The issue is coming with mysql version 5.7 and above.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message