hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21832) New metrics to get the average queue/serving/response time
Date Fri, 07 Jun 2019 16:01:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21832?focusedWorklogId=256007&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-256007
]

ASF GitHub Bot logged work on HIVE-21832:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Jun/19 16:00
            Start Date: 07/Jun/19 16:00
    Worklog Time Spent: 10m 
      Work Description: b-slim commented on pull request #665: HIVE-21832: New metrics to
get the average queue/serving/response time
URL: https://github.com/apache/hive/pull/665#discussion_r291656149
 
 

 ##########
 File path: llap-server/src/java/org/apache/hadoop/hive/llap/metrics/LlapDaemonExecutorMetrics.java
 ##########
 @@ -195,14 +202,22 @@ private LlapDaemonExecutorMetrics(String displayName, JvmMetrics jm,
String sess
       this.executorThreadUserTime[i] = registry.newGauge(miu, 0L);
       this.executorNames.put(ContainerRunnerImpl.THREAD_NAME_FORMAT_PREFIX + i, i);
     }
+    if (simpleAverageWindowDataSize > 0) {
+      this.queueTime = new SynchronizedDescriptiveStatistics(simpleAverageWindowDataSize);
 
 Review comment:
   took quick look at the implementation of `SynchronizedDescriptiveStatistics`  and i see
synchronized everywhere,
   maybe be this is not an issue yet but i can see how it can be become an issue in the future
as a source of contentions, wondering if we can use a longAdder to compute ourself the the
average, that should be lock free and will probably spread the contention. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 256007)
    Time Spent: 20m  (was: 10m)

> New metrics to get the average queue/serving/response time
> ----------------------------------------------------------
>
>                 Key: HIVE-21832
>                 URL: https://issues.apache.org/jira/browse/HIVE-21832
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21832.2.patch, HIVE-21832.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Simple [DescriptiveStatistics|https://commons.apache.org/proper/commons-math/javadocs/api-3.6/src-html/org/apache/commons/math3/stat/descriptive/DescriptiveStatistics.html#line.60] with
window size would do here. Time is not important in this case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message