hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21830) Break up DDLTask - extract rest of the Alter Table operations
Date Thu, 13 Jun 2019 05:27:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862729#comment-16862729
] 

Hive QA commented on HIVE-21830:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12971568/HIVE-21830.05.patch

{color:green}SUCCESS:{color} +1 due to 7 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 16055 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[hbase_ddl] (batchId=284)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_non_native] (batchId=101)
org.apache.hadoop.hive.ql.TestWarehouseExternalDir.org.apache.hadoop.hive.ql.TestWarehouseExternalDir
(batchId=257)
org.apache.hadoop.hive.ql.TestWarehouseExternalDir.testExternalDefaultPaths (batchId=257)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17548/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17548/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17548/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12971568 - PreCommit-HIVE-Build

> Break up DDLTask - extract rest of the Alter Table operations
> -------------------------------------------------------------
>
>                 Key: HIVE-21830
>                 URL: https://issues.apache.org/jira/browse/HIVE-21830
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>    Affects Versions: 3.1.1
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: refactor-ddl
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21830.01.patch, HIVE-21830.02.patch, HIVE-21830.03.patch, HIVE-21830.04.patch,
HIVE-21830.05.patch
>
>
> DDLTask is a huge class, more than 5000 lines long. The related DDLWork is also a huge
class, which has a field for each DDL operation it supports. The goal is to refactor these
in order to have everything cut into more handleable classes under the package  org.apache.hadoop.hive.ql.exec.ddl:
>  * have a separate class for each operation
>  * have a package for each operation group (database ddl, table ddl, etc), so the amount
of classes under a package is more manageable
>  * make all the requests (DDLDesc subclasses) immutable
>  * DDLTask should be agnostic to the actual operations
>  * right now let's ignore the issue of having some operations handled by DDLTask which
are not actual DDL operations (lock, unlock, desc...)
> In the interim time when there are two DDLTask and DDLWork classes in the code base the
new ones in the new package are called DDLTask2 and DDLWork2 thus avoiding the usage of fully
qualified class names where both the old and the new classes are in use.
> Step #10: extract the alter table operations that left from the old DDLTask, and move
them under the new packages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message