hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (JIRA)" <>
Subject [jira] [Commented] (HIVE-21830) Break up DDLTask - extract rest of the Alter Table operations
Date Wed, 12 Jun 2019 09:10:00 GMT


Zoltan Haindrich commented on HIVE-21830:

In HiveMetaHook  there seems to be some changes which might affect implementations of it.
In 7999a4abee6f2aad0de86788980588e60812cac9 there were also some changes to a similar thing
I think undoing that change as well  would be better; and create a separate ticket about changing

> Break up DDLTask - extract rest of the Alter Table operations
> -------------------------------------------------------------
>                 Key: HIVE-21830
>                 URL:
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>    Affects Versions: 3.1.1
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: refactor-ddl
>             Fix For: 4.0.0
>         Attachments: HIVE-21830.01.patch, HIVE-21830.02.patch, HIVE-21830.03.patch, HIVE-21830.04.patch
> DDLTask is a huge class, more than 5000 lines long. The related DDLWork is also a huge
class, which has a field for each DDL operation it supports. The goal is to refactor these
in order to have everything cut into more handleable classes under the package  org.apache.hadoop.hive.ql.exec.ddl:
>  * have a separate class for each operation
>  * have a package for each operation group (database ddl, table ddl, etc), so the amount
of classes under a package is more manageable
>  * make all the requests (DDLDesc subclasses) immutable
>  * DDLTask should be agnostic to the actual operations
>  * right now let's ignore the issue of having some operations handled by DDLTask which
are not actual DDL operations (lock, unlock, desc...)
> In the interim time when there are two DDLTask and DDLWork classes in the code base the
new ones in the new package are called DDLTask2 and DDLWork2 thus avoiding the usage of fully
qualified class names where both the old and the new classes are in use.
> Step #10: extract the alter table operations that left from the old DDLTask, and move
them under the new packages.

This message was sent by Atlassian JIRA

View raw message