hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16655) LLAP: Avoid preempting fragments before they enter the running state
Date Fri, 07 Jun 2019 06:16:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858334#comment-16858334
] 

Hive QA commented on HIVE-16655:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 36s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 17s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 14s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 25s{color} | {color:blue}
llap-tez in master has 17 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 11s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 16s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 18s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 18s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 13s{color} | {color:red}
llap-tez: The patch generated 9 new + 187 unchanged - 6 fixed = 196 total (was 193) {color}
|
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 38s{color} | {color:red}
llap-tez generated 2 new + 15 unchanged - 2 fixed = 17 total (was 17) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 11s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 16s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m  3s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:llap-tez |
|  |  org.apache.hadoop.hive.llap.tezplugins.LlapTaskSchedulerService$TaskAssignTimeComparator
implements Comparator but not Serializable  At LlapTaskSchedulerService.java:Serializable
 At LlapTaskSchedulerService.java:[lines 3024-3040] |
|  |  Inconsistent synchronization of org.apache.hadoop.hive.llap.tezplugins.LlapTaskSchedulerService$TaskInfo.state;
locked 50% of time  Unsynchronized access at LlapTaskSchedulerService.java:50% of time  Unsynchronized
access at LlapTaskSchedulerService.java:[line 2944] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17465/dev-support/hive-personality.sh
|
| git revision | master / e7f2fccd |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17465/yetus/diff-checkstyle-llap-tez.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17465/yetus/new-findbugs-llap-tez.html
|
| modules | C: llap-tez U: llap-tez |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17465/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> LLAP: Avoid preempting fragments before they enter the running state
> --------------------------------------------------------------------
>
>                 Key: HIVE-16655
>                 URL: https://issues.apache.org/jira/browse/HIVE-16655
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Siddharth Seth
>            Assignee: slim bouguerra
>            Priority: Major
>         Attachments: HIVE-16655.01.patch, HIVE-16655.02.patch, HIVE-16655.3.patch, HIVE-16655.3.patch
>
>
> Currently in the AM, fragments may be preempted as soon as they are allocated, without
knowing whether they will move into the RUNNING state or not. Leads to a lot of unnecessary
kills.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message