hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21783) Avoid authentication for connection from the same domain
Date Thu, 30 May 2019 09:55:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21783?focusedWorklogId=250869&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-250869
]

ASF GitHub Bot logged work on HIVE-21783:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/May/19 09:54
            Start Date: 30/May/19 09:54
    Worklog Time Spent: 10m 
      Work Description: ashutosh-bapat commented on pull request #648: HIVE-21783: Accept
Hive connections from the same domain without authentication.
URL: https://github.com/apache/hive/pull/648#discussion_r288928805
 
 

 ##########
 File path: service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java
 ##########
 @@ -75,6 +89,70 @@ private PlainSaslHelper() {
     throw new UnsupportedOperationException("Can't initialize class");
   }
 
+  public static final class DualSaslTransportFactory extends TTransportFactory {
+    TTransportFactory otherFactory;
+    TTransportFactory noAuthFactory;
+    String hiveHost;
+
+    public DualSaslTransportFactory(TTransportFactory otherFactory, String hiveHost)
+            throws LoginException {
+      this.noAuthFactory = getPlainTransportFactory(AuthMethods.NONE.toString());
+      this.otherFactory = otherFactory;
+      this.hiveHost = hiveHost;
+    }
+
+    // Return true if the IP address is from the same domain as the server.
+    private boolean isSameDomainConnection(InetAddress remoteInetAddress) {
+      String[] hiveHostSplit = null;
+      if (hiveHost != null) {
+        hiveHostSplit = hiveHost.split("\\.");
+      }
+
+      String clientHostName = remoteInetAddress.getCanonicalHostName();
+      String[] clientHostSplit = null;
+      if (clientHostName != null) {
+        clientHostSplit = clientHostName.split("\\.");
+      }
+
+      // TODO: the callers should also pass the server address or obtain in by using some
other
+      //  method. Then check whether the connection's remote address is from the same domain
as
+      //  the server. For now, for the sake of testing, return true. We need to understand
what
+      //  exactly it means to have connection from the same domain.
+      // For now, two hosts are in the same domain if the last two parts in their hostname
are same.
+      if (hiveHostSplit.length >= 2 && clientHostSplit.length >= 2) {
 
 Review comment:
   As per the latest approach, the trusted domain will be configured and thus we do not rely
on hivehost to know the trusted domain.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 250869)
    Time Spent: 1.5h  (was: 1h 20m)

> Avoid authentication for connection from the same domain
> --------------------------------------------------------
>
>                 Key: HIVE-21783
>                 URL: https://issues.apache.org/jira/browse/HIVE-21783
>             Project: Hive
>          Issue Type: New Feature
>          Components: HiveServer2
>            Reporter: Ashutosh Bapat
>            Assignee: Ashutosh Bapat
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> When a connection comes from the same domain do not authenticate the user. This is similar
to NONE authentication but only for the connection from the same domain.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message