hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21576) Introduce CAST...FORMAT and limited list of SQL:2016 datetime formats
Date Mon, 27 May 2019 20:04:01 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849173#comment-16849173
] 

Hive QA commented on HIVE-21576:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 56s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 22s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 59s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 25s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 37s{color} | {color:blue}
common in master has 62 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 47s{color} | {color:blue}
serde in master has 193 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 43s{color} | {color:blue}
ql in master has 2258 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 46s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 31s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 27s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 10s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 10s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 15s{color} | {color:red}
common: The patch generated 40 new + 5 unchanged - 2 fixed = 45 total (was 7) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 19s{color} | {color:red}
serde: The patch generated 3 new + 213 unchanged - 4 fixed = 216 total (was 217) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 52s{color} | {color:red}
ql: The patch generated 27 new + 451 unchanged - 31 fixed = 478 total (was 482) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  5m  0s{color} | {color:red}
ql generated 44 new + 2229 unchanged - 29 fixed = 2273 total (was 2258) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 48s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 18s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 21s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToCharWithFormat defines
non-transient non-serializable instance field formatter  In CastDateToCharWithFormat.java:instance
field formatter  In CastDateToCharWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastDateToCharWithFormat.formatter  At CastDateToCharWithFormat.java:CastDateToCharWithFormat.formatter
 At CastDateToCharWithFormat.java:[line 43] |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToString.func(BytesColumnVector,
long[], int, HiveDateTimeFormatter):in org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToString.func(BytesColumnVector,
long[], int, HiveDateTimeFormatter): String.getBytes()  At CastDateToString.java:[line 57]
|
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToStringWithFormat defines
non-transient non-serializable instance field formatter  In CastDateToStringWithFormat.java:instance
field formatter  In CastDateToStringWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastDateToStringWithFormat.formatter  At CastDateToStringWithFormat.java:CastDateToStringWithFormat.formatter
 At CastDateToStringWithFormat.java:[line 48] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToVarCharWithFormat
defines non-transient non-serializable instance field formatter  In CastDateToVarCharWithFormat.java:instance
field formatter  In CastDateToVarCharWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastDateToVarCharWithFormat.formatter  At CastDateToVarCharWithFormat.java:CastDateToVarCharWithFormat.formatter
 At CastDateToVarCharWithFormat.java:[line 43] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastStringToDateWithFormat defines
non-transient non-serializable instance field formatter  In CastStringToDateWithFormat.java:instance
field formatter  In CastStringToDateWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastStringToDateWithFormat.formatter  At CastStringToDateWithFormat.java:CastStringToDateWithFormat.formatter
 At CastStringToDateWithFormat.java:[line 48] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastStringToTimestampWithFormat
defines non-transient non-serializable instance field formatter  In CastStringToTimestampWithFormat.java:instance
field formatter  In CastStringToTimestampWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastStringToTimestampWithFormat.formatter  At CastStringToTimestampWithFormat.java:CastStringToTimestampWithFormat.formatter
 At CastStringToTimestampWithFormat.java:[line 48] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToCharWithFormat
defines non-transient non-serializable instance field formatter  In CastTimestampToCharWithFormat.java:instance
field formatter  In CastTimestampToCharWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastTimestampToCharWithFormat.formatter  At CastTimestampToCharWithFormat.java:CastTimestampToCharWithFormat.formatter
 At CastTimestampToCharWithFormat.java:[line 44] |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToString.func(BytesColumnVector,
TimestampColumnVector, int, HiveDateTimeFormatter):in org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToString.func(BytesColumnVector,
TimestampColumnVector, int, HiveDateTimeFormatter): String.getBytes()  At CastTimestampToString.java:[line
58] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToStringWithFormat
defines non-transient non-serializable instance field formatter  In CastTimestampToStringWithFormat.java:instance
field formatter  In CastTimestampToStringWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastTimestampToStringWithFormat.formatter  At CastTimestampToStringWithFormat.java:CastTimestampToStringWithFormat.formatter
 At CastTimestampToStringWithFormat.java:[line 47] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToVarCharWithFormat
defines non-transient non-serializable instance field formatter  In CastTimestampToVarCharWithFormat.java:instance
field formatter  In CastTimestampToVarCharWithFormat.java |
|  |  org.apache.hadoop.hive.common.format.datetime.HiveSqlDateTimeFormatter stored into non-transient
field CastTimestampToVarCharWithFormat.formatter  At CastTimestampToVarCharWithFormat.java:CastTimestampToVarCharWithFormat.formatter
 At CastTimestampToVarCharWithFormat.java:[line 44] |
|  |  Dead store to KW_IN243 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceSimilarExpressionAtom(CommonTree)
 At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceSimilarExpressionAtom(CommonTree)
 At HiveParser_IdentifiersParser.java:[line 9591] |
|  |  Dead store to LPAREN233 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression()
 At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression()
 At HiveParser_IdentifiersParser.java:[line 9093] |
|  |  Dead store to RPAREN235 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression()
 At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression()
 At HiveParser_IdentifiersParser.java:[line 9100] |
|  |  Redundant nullcheck of nonReserved313, which is known to be non-null in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.identifier()
 Redundant null check at HiveParser_IdentifiersParser.java:is known to be non-null in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.identifier()
 Redundant null check at HiveParser_IdentifiersParser.java:[line 12340] |
|  |  Switch statement found in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.castExpression()
where default case is missing  At HiveParser_IdentifiersParser.java:where default case is
missing  At HiveParser_IdentifiersParser.java:[lines 3964-3975] |
|  |  Dead store to LA31_100 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33367] |
|  |  Dead store to LA31_101 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33380] |
|  |  Dead store to LA31_102 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33393] |
|  |  Dead store to LA31_15 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33263] |
|  |  Dead store to LA31_16 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33276] |
|  |  Dead store to LA31_17 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33289] |
|  |  Dead store to LA31_18 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33302] |
|  |  Dead store to LA31_19 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33315] |
|  |  Dead store to LA31_97 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33328] |
|  |  Dead store to LA31_98 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33341] |
|  |  Dead store to LA31_99 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33354] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32 be a _static_
inner class?  At HiveParser_IdentifiersParser.java:inner class?  At HiveParser_IdentifiersParser.java:[lines
33539-33552] |
|  |  Dead store to LA36_169 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA36.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA36.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 33839] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA38 be a _static_
inner class?  At HiveParser_IdentifiersParser.java:inner class?  At HiveParser_IdentifiersParser.java:[lines
35049-35062] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA47 be a _static_
inner class?  At HiveParser_IdentifiersParser.java:inner class?  At HiveParser_IdentifiersParser.java:[lines
35970-35983] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA51 be a _static_
inner class?  At HiveParser_IdentifiersParser.java:inner class?  At HiveParser_IdentifiersParser.java:[lines
36459-36472] |
|  |  Dead store to LA54_48 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 36717] |
|  |  Dead store to LA54_56 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 36730] |
|  |  Dead store to LA54_57 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 36743] |
|  |  Dead store to LA54_58 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 36756] |
|  |  Dead store to LA54_59 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream)  At HiveParser_IdentifiersParser.java:[line 36769] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17320/dev-support/hive-personality.sh
|
| git revision | master / 5bc0364 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17320/yetus/diff-checkstyle-common.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17320/yetus/diff-checkstyle-serde.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17320/yetus/diff-checkstyle-ql.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17320/yetus/new-findbugs-ql.html
|
| modules | C: common serde ql U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17320/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Introduce CAST...FORMAT and limited list of SQL:2016 datetime formats
> ---------------------------------------------------------------------
>
>                 Key: HIVE-21576
>                 URL: https://issues.apache.org/jira/browse/HIVE-21576
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Karen Coppage
>            Assignee: Karen Coppage
>            Priority: Major
>         Attachments: HIVE-21576.01.patch, HIVE-21576.03.patch, HIVE-21576.04.patch, HIVE-21576.2.patch
>
>
> Introduce FORMAT clause to CAST statements as well as the below limited list of SQL:2016
datetime formats to Hive in general. These can be used if a session-level feature flag is
turned on.
>  * YYYY
>  * MM
>  * DD
>  * HH
>  * MI
>  * SS
> Definitions of these formats here: [https://docs.google.com/document/d/1V7k6-lrPGW7_uhqM-FhKl3QsxwCRy69v2KIxPsGjc1k/|https://docs.google.com/document/d/1V7k6-lrPGW7_uhqM-FhKl3QsxwCRy69v2KIxPsGjc1k/edit]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message