From issues-return-154859-archive-asf-public=cust-asf.ponee.io@hive.apache.org Mon Apr 1 10:01:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4C3AD180621 for ; Mon, 1 Apr 2019 12:01:05 +0200 (CEST) Received: (qmail 86384 invoked by uid 500); 1 Apr 2019 10:01:04 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 86375 invoked by uid 99); 1 Apr 2019 10:01:04 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Apr 2019 10:01:04 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8A98BE277B for ; Mon, 1 Apr 2019 10:01:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 06F532459D for ; Mon, 1 Apr 2019 10:01:03 +0000 (UTC) Date: Mon, 1 Apr 2019 10:01:03 +0000 (UTC) From: "Peter Vary (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-9995) ACID compaction tries to compact a single file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806592#comment-16806592 ] Peter Vary commented on HIVE-9995: ---------------------------------- [~dkuzmenko]: Rebase please :( > ACID compaction tries to compact a single file > ---------------------------------------------- > > Key: HIVE-9995 > URL: https://issues.apache.org/jira/browse/HIVE-9995 > Project: Hive > Issue Type: Bug > Components: Transactions > Affects Versions: 1.0.0 > Reporter: Eugene Koifman > Assignee: Denys Kuzmenko > Priority: Major > Attachments: HIVE-9995.01.patch, HIVE-9995.02.patch, HIVE-9995.03.patch, HIVE-9995.04.patch, HIVE-9995.05.patch, HIVE-9995.06.patch, HIVE-9995.07.patch, HIVE-9995.08.patch, HIVE-9995.WIP.patch > > > Consider TestWorker.minorWithOpenInMiddle() > since there is an open txnId=23, this doesn't have any meaningful minor compaction work to do. The system still tries to compact a single delta file for 21-22 id range, and effectively copies the file onto itself. > This is 1. inefficient and 2. can potentially affect a reader. > (from a real cluster) > Suppose we start with > {noformat} > drwxr-xr-x - ekoifman staff 0 2016-06-09 16:03 /user/hive/warehouse/t/base_0000016 > -rw-r--r-- 1 ekoifman staff 602 2016-06-09 16:03 /user/hive/warehouse/t/base_0000016/bucket_00000 > drwxr-xr-x - ekoifman staff 0 2016-06-09 16:07 /user/hive/warehouse/t/base_0000017 > -rw-r--r-- 1 ekoifman staff 588 2016-06-09 16:07 /user/hive/warehouse/t/base_0000017/bucket_00000 > drwxr-xr-x - ekoifman staff 0 2016-06-09 16:07 /user/hive/warehouse/t/delta_0000017_0000017_0000 > -rw-r--r-- 1 ekoifman staff 514 2016-06-09 16:06 /user/hive/warehouse/t/delta_0000017_0000017_0000/bucket_00000 > drwxr-xr-x - ekoifman staff 0 2016-06-09 16:07 /user/hive/warehouse/t/delta_0000018_0000018_0000 > -rw-r--r-- 1 ekoifman staff 612 2016-06-09 16:07 /user/hive/warehouse/t/delta_0000018_0000018_0000/bucket_00000 > {noformat} > then do _alter table T compact 'minor';_ > then we end up with > {noformat} > drwxr-xr-x - ekoifman staff 0 2016-06-09 16:07 /user/hive/warehouse/t/base_0000017 > -rw-r--r-- 1 ekoifman staff 588 2016-06-09 16:07 /user/hive/warehouse/t/base_0000017/bucket_00000 > drwxr-xr-x - ekoifman staff 0 2016-06-09 16:11 /user/hive/warehouse/t/delta_0000018_0000018 > -rw-r--r-- 1 ekoifman staff 500 2016-06-09 16:11 /user/hive/warehouse/t/delta_0000018_0000018/bucket_00000 > drwxr-xr-x - ekoifman staff 0 2016-06-09 16:07 /user/hive/warehouse/t/delta_0000018_0000018_0000 > -rw-r--r-- 1 ekoifman staff 612 2016-06-09 16:07 /user/hive/warehouse/t/delta_0000018_0000018_0000/bucket_00000 > {noformat} > So compaction created a new dir _/user/hive/warehouse/t/delta_0000018_0000018_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)