hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21662) Refactor some functionality from QTestUtil to separate classes
Date Tue, 30 Apr 2019 11:37:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830208#comment-16830208
] 

Hive QA commented on HIVE-21662:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 50s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 50s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  7s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 30s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 45s{color} | {color:blue}
itests/util in master has 46 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 40s{color} | {color:blue}
itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 43s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 28s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m  9s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  8s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  8s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 14s{color} | {color:red}
itests/util: The patch generated 32 new + 194 unchanged - 42 fixed = 226 total (was 236) {color}
|
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 50s{color} | {color:red}
itests/util generated 2 new + 42 unchanged - 4 fixed = 44 total (was 46) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 40s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 14s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 18m 50s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:itests/util |
|  |  Exceptional return value of java.io.File.delete() ignored in org.apache.hadoop.hive.ql.QTestResultProcessor.executeDiffCommand(String,
String, boolean, String)  At QTestResultProcessor.java:ignored in org.apache.hadoop.hive.ql.QTestResultProcessor.executeDiffCommand(String,
String, boolean, String)  At QTestResultProcessor.java:[line 141] |
|  |  org.apache.hadoop.hive.ql.QTestUtil.DEBUG_HINT isn't final but should be  At QTestUtil.java:be
 At QTestUtil.java:[line 94] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17080/dev-support/hive-personality.sh
|
| git revision | master / 0f8119f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17080/yetus/diff-checkstyle-itests_util.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-17080/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17080/yetus/new-findbugs-itests_util.html
|
| modules | C: itests/util itests/hive-unit U: itests |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17080/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Refactor some functionality from QTestUtil to separate classes
> --------------------------------------------------------------
>
>                 Key: HIVE-21662
>                 URL: https://issues.apache.org/jira/browse/HIVE-21662
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Laszlo Bodor
>            Assignee: Laszlo Bodor
>            Priority: Major
>         Attachments: HIVE-21662.01.patch
>
>
> This may be a follow-up of HIVE-18560:
> new classes: QTestSystemProperties, QFileVersionHandler, QTestMiniClusters, QTestDatasetHandler,
QTestResultProcessor



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message