hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21531) Vectorization: all NULL hashcodes are not computed using Murmur3
Date Wed, 24 Apr 2019 02:36:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824759#comment-16824759
] 

Hive QA commented on HIVE-21531:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12966814/HIVE-21531.2.patch

{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 15923 tests executed
*Failed tests:*
{noformat}
TestReplAcidTablesWithJsonMessage - did not produce a TEST-*.xml file (likely timed out) (batchId=256)
TestReplicationScenariosAcidTables - did not produce a TEST-*.xml file (likely timed out)
(batchId=258)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17022/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17022/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17022/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12966814 - PreCommit-HIVE-Build

> Vectorization: all NULL hashcodes are not computed using Murmur3
> ----------------------------------------------------------------
>
>                 Key: HIVE-21531
>                 URL: https://issues.apache.org/jira/browse/HIVE-21531
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 4.0.0, 3.1.1
>            Reporter: Gopal V
>            Assignee: Gopal V
>            Priority: Critical
>         Attachments: HIVE-21531.1.patch, HIVE-21531.1.patch, HIVE-21531.2.patch, HIVE-21531.WIP.patch
>
>
> The comments in Vectorized hash computation call out the MurmurHash implementation (the
one using 0x5bd1e995), while the non-vectorized codepath calls out the Murmur3 one (using
0xcc9e2d51).
> The comments here are wrong
> {code}
>  /**
>    * Batch compute the hash codes for all the serialized keys.
>    *
>    * NOTE: MAJOR MAJOR ASSUMPTION:
>    *     We assume that HashCodeUtil.murmurHash produces the same result
>    *     as MurmurHash.hash with seed = 0 (the method used by ReduceSinkOperator for
>    *     UNIFORM distribution).
>    */
>   protected void computeSerializedHashCodes() {
>     int offset = 0;
>     int keyLength;
>     byte[] bytes = output.getData();
>     for (int i = 0; i < nonNullKeyCount; i++) {
>       keyLength = serializedKeyLengths[i];
>       hashCodes[i] = Murmur3.hash32(bytes, offset, keyLength, 0);
>       offset += keyLength;
>     }
>   }
> {code}
> but the wrong comment is followed in the Vector RS operator 
> {code}
>       System.arraycopy(nullKeyOutput.getData(), 0, nullBytes, 0, nullBytesLength);
>       nullKeyHashCode = HashCodeUtil.calculateBytesHashCode(nullBytes, 0, nullBytesLength);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message