hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Bodor (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-21465) Introduce a base abstract VectorExpression to eliminate further code duplications
Date Sat, 06 Apr 2019 08:54:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Laszlo Bodor updated HIVE-21465:
--------------------------------
    Attachment: HIVE-21465.benchmark.patch

> Introduce a base abstract VectorExpression to eliminate further code duplications
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-21465
>                 URL: https://issues.apache.org/jira/browse/HIVE-21465
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Laszlo Bodor
>            Assignee: Laszlo Bodor
>            Priority: Major
>         Attachments: HIVE-21465.01.patch, HIVE-21465.02.patch, HIVE-21465.benchmark.patch
>
>
> In vectorized expressions, from time to time, I see a similar/same logic to be repeated,
which always consists of some stuff like:
> 1. some inner loops (even the comments are the same)
> {code}
> grep -iRH "Set isNull before call in case it changes it mind" | grep "ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/"
> {code}
> 2. call to an actual "business logic" function ==> 1 line which could be abstracted...
and it has been abstracted in hive codebase in n different cases.
> However, an abstract BaseVectorExpression would not force anybody to extend it instead
of VectorExpression and not copy the code again, but it could be a good start and an example.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message