hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21109) Stats replication for ACID tables.
Date Mon, 01 Apr 2019 09:39:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21109?focusedWorklogId=221179&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221179
]

ASF GitHub Bot logged work on HIVE-21109:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/19 09:38
            Start Date: 01/Apr/19 09:38
    Worklog Time Spent: 10m 
      Work Description: ashutosh-bapat commented on pull request #579: HIVE-21109 : Support
stats replication for ACID tables.
URL: https://github.com/apache/hive/pull/579#discussion_r270786715
 
 

 ##########
 File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestStatsReplicationScenarios.java
 ##########
 @@ -269,11 +294,23 @@ private String dumpLoadVerify(List<String> tableNames, String
lastReplicationId,
     WarehouseInstance.Tuple dumpTuple = primary.run("use " + primaryDbName)
             .dump(primaryDbName, lastReplicationId, withClauseList);
 
+
     // Load, if necessary changing configuration.
     if (parallelLoad) {
       replica.hiveConf.setBoolVar(HiveConf.ConfVars.EXECPARALLEL, true);
     }
 
+    // Fail load if for testing failure and retry scenario. Fail the load while setting
+    // checkpoint for a table in the middle of list of tables.
+    if (failRetry) {
+      if (lastReplicationId == null) {
+        failBootstrapLoad(dumpTuple, tableNames.size()/2);
+      } else {
+        failIncrementalLoad(dumpTuple, tableNames.size()/2);
 
 Review comment:
   We are counting UpdateTableStats or UpdatePartStats events and not every event. So, we
will fail only after encountering no of tables/2 events of those types. So it can not fail
before applying update stats events. But to be on the safer side, I have changed the code
to fail after second event so that we have at least one successful application before we fail.
Since we are performing multiple insert events per table, we can be sure that there are at
least 2 events of each type.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 221179)
    Time Spent: 9h 50m  (was: 9h 40m)

> Stats replication for ACID tables.
> ----------------------------------
>
>                 Key: HIVE-21109
>                 URL: https://issues.apache.org/jira/browse/HIVE-21109
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Ashutosh Bapat
>            Assignee: Ashutosh Bapat
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21109.01.patch, HIVE-21109.02.patch, HIVE-21109.03.patch, HIVE-21109.04.patch,
HIVE-21109.05.patch, HIVE-21109.06.patch, HIVE-21109.07.patch, HIVE-21109.08.patch
>
>          Time Spent: 9h 50m
>  Remaining Estimate: 0h
>
> Transactional tables require a writeID associated with the stats update. This writeId
needs to be in sync with the writeId on the source and hence needs to be replicated from
the source.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message