hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (HIVE-21109) Stats replication for ACID tables.
Date Mon, 01 Apr 2019 06:51:00 GMT


ASF GitHub Bot logged work on HIVE-21109:

                Author: ASF GitHub Bot
            Created on: 01/Apr/19 06:50
            Start Date: 01/Apr/19 06:50
    Worklog Time Spent: 10m 
      Work Description: ashutosh-bapat commented on pull request #579: HIVE-21109 : Support
stats replication for ACID tables.

 File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/
 @@ -2950,21 +2957,32 @@ public Partition createPartition(Table tbl, Map<String, String>
partSpec) throws
     int size = addPartitionDesc.getPartitionCount();
     List<org.apache.hadoop.hive.metastore.api.Partition> in =
         new ArrayList<org.apache.hadoop.hive.metastore.api.Partition>(size);
-    AcidUtils.TableSnapshot tableSnapshot = AcidUtils.getTableSnapshot(conf, tbl, true);
     long writeId;
     String validWriteIdList;
-    if (tableSnapshot != null && tableSnapshot.getWriteId() > 0) {
-      writeId = tableSnapshot.getWriteId();
-      validWriteIdList = tableSnapshot.getValidWriteIdList();
+    // In case of replication, get the writeId from the source and use valid write Id list
+    // for replication.
+    if (addPartitionDesc.getReplicationSpec().isInReplicationScope() &&
+        addPartitionDesc.getPartition(0).getWriteId() > 0) {
 Review comment:
   writeId will be 0 for non-transactional tables. Also this is createPartitions code, which
may get executed for with writeId = 0 for non-transactional modifications to partitions for
transactional tables as well. The condition, which I borrowed from the old code is required
so that we don't create a valid writeId list or try to get a table snapshot when writeId is
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 221122)
    Time Spent: 9h 40m  (was: 9.5h)

> Stats replication for ACID tables.
> ----------------------------------
>                 Key: HIVE-21109
>                 URL:
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Ashutosh Bapat
>            Assignee: Ashutosh Bapat
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21109.01.patch, HIVE-21109.02.patch, HIVE-21109.03.patch, HIVE-21109.04.patch,
HIVE-21109.05.patch, HIVE-21109.06.patch, HIVE-21109.07.patch, HIVE-21109.08.patch
>          Time Spent: 9h 40m
>  Remaining Estimate: 0h
> Transactional tables require a writeID associated with the stats update. This writeId
needs to be in sync with the writeId on the source and hence needs to be replicated from
the source.

This message was sent by Atlassian JIRA

View raw message