From issues-return-154671-archive-asf-public=cust-asf.ponee.io@hive.apache.org Sat Mar 30 07:18:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1ADA618077A for ; Sat, 30 Mar 2019 08:18:01 +0100 (CET) Received: (qmail 21056 invoked by uid 500); 30 Mar 2019 07:18:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 20936 invoked by uid 99); 30 Mar 2019 07:18:00 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 30 Mar 2019 07:18:00 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 79654E2831 for ; Sat, 30 Mar 2019 07:18:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 291282459B for ; Sat, 30 Mar 2019 07:18:00 +0000 (UTC) Date: Sat, 30 Mar 2019 07:18:00 +0000 (UTC) From: "Laszlo Bodor (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HIVE-21541) Fix missing asf headers from HIVE-15406 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21541?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1680= 5513#comment-16805513 ]=20 Laszlo Bodor edited comment on HIVE-21541 at 3/30/19 7:17 AM: -------------------------------------------------------------- thanks [~pvary], [~kgyrtkirk] !=C2=A0I double-checked, and I found the root= cause of duplications...I copied it from GenericUDFTrunc :) [https://github.com/apache/hive/blob/a7a9f516b3803830999f60d2bffb45e76c8a9= 1ef/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java#= L2-L3] so, seems like it's a pattern, which could have spread in the codebase, we = should check that... =C2=A0 UPDATE: only a few occurences=C2=A0found {code} =C2=A0grep -src Licensed to the Apache Software Foundation . | grep -v ':0$= ' | grep -v ':1$' | grep java ./standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hiv= e/metastore/conf/ConfTemplatePrinter.java:2 ./common/src/java/org/apache/hadoop/hive/ant/GenHiveTemplate.java:2 ./ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java:2 ./ql/src/test/org/apache/hadoop/hive/ql/exec/TestOperatorNames.java:2 {code} was (Author: abstractdog): thanks [~pvary], [~kgyrtkirk] !=C2=A0I double-checked, and I found the root= cause of duplications...I copied it from GenericUDFTrunc :) [https://github.com/apache/hive/blob/a7a9f516b3803830999f60d2bffb45e76c8a91= ef/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java#L= 2-L3] so, seems like it's a pattern, which could have spread in the codebase, we = should check that... > Fix missing asf headers from HIVE-15406 > --------------------------------------- > > Key: HIVE-21541 > URL: https://issues.apache.org/jira/browse/HIVE-21541 > Project: Hive > Issue Type: Bug > Reporter: Laszlo Bodor > Assignee: Laszlo Bodor > Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21541.01.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)