From issues-return-154410-archive-asf-public=cust-asf.ponee.io@hive.apache.org Thu Mar 28 12:29:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0357918076D for ; Thu, 28 Mar 2019 13:29:01 +0100 (CET) Received: (qmail 12300 invoked by uid 500); 28 Mar 2019 12:29:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 12291 invoked by uid 99); 28 Mar 2019 12:29:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Mar 2019 12:29:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8F3D1E2998 for ; Thu, 28 Mar 2019 12:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 358F92459B for ; Thu, 28 Mar 2019 12:29:00 +0000 (UTC) Date: Thu, 28 Mar 2019 12:29:00 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-21516) Fix spark downloading for q tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21516?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1680= 3880#comment-16803880 ]=20 Hive QA commented on HIVE-21516: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 48s= {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 7m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1= m 15s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 48s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 28s= {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 1m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1= m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m = 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s{color} | {color:green} The patch has no whitespace issues. {color}= | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 4= s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 49s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 1= 4s{color} | {color:red} The patch generated 7 ASF License warnings. {color}= | | {color:black}{color} | {color:black} {color} | {color:black} 15m 51s{colo= r} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc xml compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16= .36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16734/de= v-support/hive-personality.sh | | git revision | master / 1e58bd2 | | Default Java | 1.8.0_111 | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-16734/yetu= s/patch-asflicense-problems.txt | | modules | C: itests itests/hive-unit itests/qtest-spark U: itests | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16734/= yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Fix spark downloading for q tests > --------------------------------- > > Key: HIVE-21516 > URL: https://issues.apache.org/jira/browse/HIVE-21516 > Project: Hive > Issue Type: Bug > Components: Hive > Affects Versions: 3.1.1 > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21516.01.patch, HIVE-21516.02.patch, HIVE-21516= .03.patch, HIVE-21516.04.patch, HIVE-21516.05.patch, HIVE-21516.06.patch > > > Currently itests/pom.xml declares a command to generated the download scr= ipt for spark, thus it is re-generated every time any maven command is exec= uted for any sub project of itests. AS a side effect it is leaving download= .sh files everywhere. The download.sh file is almost totally static, no nee= d to recreate it every time, just requires $spark.version as a parameter. > Also it is only working properly under linux, as it relies on the md5sum = program which is not present in OS X. This means that if the spark tarball = is partially downloaded on OS X, then it would never be re-downloaded. This= should be fixed by making it work as well using=C2=A0md5 on OS X. -- This message was sent by Atlassian JIRA (v7.6.3#76005)