From issues-return-152281-archive-asf-public=cust-asf.ponee.io@hive.apache.org Sat Mar 9 23:53:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C9DD718062C for ; Sun, 10 Mar 2019 00:53:03 +0100 (CET) Received: (qmail 98765 invoked by uid 500); 9 Mar 2019 23:53:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 98756 invoked by uid 99); 9 Mar 2019 23:53:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Mar 2019 23:53:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 75064C2F29 for ; Sat, 9 Mar 2019 23:53:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id f-pBZTtISNI4 for ; Sat, 9 Mar 2019 23:53:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 319935FDA3 for ; Sat, 9 Mar 2019 23:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9F047E0D27 for ; Sat, 9 Mar 2019 23:53:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2C1BF257FB for ; Sat, 9 Mar 2019 23:53:00 +0000 (UTC) Date: Sat, 9 Mar 2019 23:53:00 +0000 (UTC) From: "Miklos Gergely (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-21401) Break up DDLTask - extract Table related operations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21401?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Miklos Gergely updated HIVE-21401: ---------------------------------- Status: Patch Available (was: Open) > Break up DDLTask - extract Table related operations > --------------------------------------------------- > > Key: HIVE-21401 > URL: https://issues.apache.org/jira/browse/HIVE-21401 > Project: Hive > Issue Type: Sub-task > Components: Hive > Affects Versions: 3.1.1 > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21401.01.patch, HIVE-21401.02.patch, HIVE-21401= .03.patch, HIVE-21401.04.patch, HIVE-21401.05.patch, HIVE-21401.06.patch > > > DDLTask is a huge class, more than 5000 lines long. The related DDLWork i= s also a huge class, which has a field for each=C2=A0DDL=C2=A0operation it = supports. The goal is to refactor these in order to have everything cut int= o more handleable classes under the package=C2=A0 org.apache.hadoop.hive.ql= .exec.ddl: > * have a separate class for each operation > * have a package for each operation group (database ddl, table ddl, etc)= , so the amount of classes under a package is more manageable > * make all the requests (DDLDesc subclasses) immutable > * DDLTask should be agnostic to the actual operations > * right now let's ignore the issue of having some operations handled by = DDLTask which are not actual DDL operations (lock, unlock, desc...) > In the interim time when there are two DDLTask and DDLWork classes in the= code base the new ones in the new package are called DDLTask2 and DDLWork2= thus avoiding the usage of fully qualified class names where both the old = and the new classes are in use. > Step #2: extract all the=C2=A0table related operations from the old DDLTa= sk except alter table, and move them under the new package. Also create the= new internal framework. -- This message was sent by Atlassian JIRA (v7.6.3#76005)