From issues-return-152059-archive-asf-public=cust-asf.ponee.io@hive.apache.org Fri Mar 8 03:52:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AD76F18072F for ; Fri, 8 Mar 2019 04:52:05 +0100 (CET) Received: (qmail 94197 invoked by uid 500); 8 Mar 2019 03:52:04 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 93970 invoked by uid 99); 8 Mar 2019 03:52:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Mar 2019 03:52:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C2E69C27B4 for ; Fri, 8 Mar 2019 03:52:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id iZbaeDgDcMps for ; Fri, 8 Mar 2019 03:52:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 095F860F08 for ; Fri, 8 Mar 2019 03:52:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D6CB2E282D for ; Fri, 8 Mar 2019 03:52:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 32335257D7 for ; Fri, 8 Mar 2019 03:52:00 +0000 (UTC) Date: Fri, 8 Mar 2019 03:52:00 +0000 (UTC) From: "Teddy Choi (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-21368) Vectorization: Unnecessary Decimal64 -> HiveDecimal conversion MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787498#comment-16787498 ] Teddy Choi commented on HIVE-21368: ----------------------------------- I found following code in Vectorizer.java. It was reverted in commit 470ba3e2835ef769f940d013acbe6c05d9208903 by McMcline in 2018-08-16 to revert HIVE-20315. I don't know why it was reverted. {code:java} // For now, we don't support joins on or using DECIMAL_64. VectorExpression[] allBigTableValueExpressions = vContext.getVectorExpressionsUpConvertDecimal64(bigTableExprs); {code} > Vectorization: Unnecessary Decimal64 -> HiveDecimal conversion > -------------------------------------------------------------- > > Key: HIVE-21368 > URL: https://issues.apache.org/jira/browse/HIVE-21368 > Project: Hive > Issue Type: Bug > Reporter: Gopal V > Assignee: Teddy Choi > Priority: Major > > Joins projecting Decimal64 have a suspicious cast in the inner loop > {code} > ConvertDecimal64ToDecimal(col 14:decimal(7,2)/DECIMAL_64) -> 24:decimal(7,2)' > {code} > {code} > create temporary table foo(x int , y decimal(7,2)); > create temporary table bar(x int , y decimal(7,2)); > set hive.explain.user=false; > explain vectorization detail select sum(foo.y) from foo, bar where foo.x = bar.x; > {code} > {code} > ' Map Join Operator' > ' condition map:' > ' Inner Join 0 to 1' > ' keys:' > ' 0 _col0 (type: int)' > ' 1 _col0 (type: int)' > ' Map Join Vectorization:' > ' bigTableKeyColumnNums: [0]' > ' bigTableRetainedColumnNums: [3]' > ' bigTableValueColumnNums: [3]' > ' bigTableValueExpressions: ConvertDecimal64ToDecimal(col 1:decimal(7,2)/DECIMAL_64) -> 3:decimal(7,2)' > ' className: VectorMapJoinInnerBigOnlyLongOperator' > ' native: true' > ' nativeConditionsMet: hive.mapjoin.optimized.hashtable IS true, hive.vectorized.execution.mapjoin.native.enabled IS true, hive.execution.engine tez IN [tez, spark] IS true, One MapJoin Condition IS true, No nullsafe IS true, Small table vectorizes IS true, Fast Hash Table and No Hybrid Hash Join IS true' > ' projectedOutputColumnNums: [3]' > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)