From issues-return-153726-archive-asf-public=cust-asf.ponee.io@hive.apache.org Fri Mar 22 23:39:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0F2C818064D for ; Sat, 23 Mar 2019 00:39:01 +0100 (CET) Received: (qmail 41599 invoked by uid 500); 22 Mar 2019 23:39:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 41588 invoked by uid 99); 22 Mar 2019 23:39:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Mar 2019 23:39:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A426DE26CD for ; Fri, 22 Mar 2019 23:39:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5F8C22459C for ; Fri, 22 Mar 2019 23:39:00 +0000 (UTC) Date: Fri, 22 Mar 2019 23:39:00 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-21204) Instrumentation for read/write locks in LLAP MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21204?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1679= 9440#comment-16799440 ]=20 Hive QA commented on HIVE-21204: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 44s= {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 7m 23s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1= m 16s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 51s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 3= 6s{color} | {color:blue} common in master has 63 extant Findbugs warnings. = {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 3= 4s{color} | {color:blue} llap-common in master has 76 extant Findbugs warni= ngs. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 2= 8s{color} | {color:blue} llap-tez in master has 17 extant Findbugs warnings= . {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 4= 8s{color} | {color:blue} llap-server in master has 79 extant Findbugs warni= ngs. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 58s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 29s= {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 2= 2s{color} | {color:red} llap-server in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 22s{= color} | {color:red} llap-server in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 22s{co= lor} | {color:red} llap-server in the patch failed. {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 1= 0s{color} | {color:red} llap-common: The patch generated 17 new + 0 unchang= ed - 0 fixed =3D 17 total (was 0) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 1= 5s{color} | {color:red} llap-server: The patch generated 5 new + 146 unchan= ged - 4 fixed =3D 151 total (was 150) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s{color} | {color:green} The patch has no whitespace issues. {color}= | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 21s= {color} | {color:red} llap-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 55s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 14s{color} | {color:green} The patch does not generate ASF License war= nings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 23m 12s{colo= r} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compi= le | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16= .36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16641/de= v-support/hive-personality.sh | | git revision | master / 2fa22bf | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-16641/yetu= s/patch-mvninstall-llap-server.txt | | compile | http://104.198.109.242/logs//PreCommit-HIVE-Build-16641/yetus/p= atch-compile-llap-server.txt | | javac | http://104.198.109.242/logs//PreCommit-HIVE-Build-16641/yetus/pat= ch-compile-llap-server.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-16641/yetu= s/diff-checkstyle-llap-common.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-16641/yetu= s/diff-checkstyle-llap-server.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-16641/yetus/= patch-findbugs-llap-server.txt | | modules | C: common llap-common llap-tez llap-server U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16641/= yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Instrumentation for read/write locks in LLAP > -------------------------------------------- > > Key: HIVE-21204 > URL: https://issues.apache.org/jira/browse/HIVE-21204 > Project: Hive > Issue Type: Improvement > Components: llap > Reporter: Oliver Draese > Assignee: Oliver Draese > Priority: Major > Attachments: HIVE-21204.4.patch, HIVE-21204.5.patch > > > LLAP has several R/W locks for serialization of updates to query tracker,= file data, .... > Instrumentation is added to monitor the > * total amount of R/W locks within a particular category > * average + max wait/suspension time to get the R/W lock > A category includes all lock instances for particular areas (i.e. categor= y is FileData and all R/W locks that are used in FileData instances are acc= ounted within the one category). > The monitoring/accounting is done via Hadoop Metrics 2, making them acces= sible via JMX. In addition, a new "locking" GET endpoint is added to the LL= AP daemon's REST interface. It produces output like the following example: > { > {{=C2=A0 "statsCollection": "enabled",}} > {{=C2=A0 "lockStats": [}} > {{=C2=A0 =C2=A0 {}}{{=C2=A0"type": "R/W Lock Stats",}} > {{=C2=A0 =C2=A0 =C2=A0 "label": "FileData",}} > {{=C2=A0 =C2=A0 =C2=A0 "totalLockWaitTimeMillis": 0,}} > {{=C2=A0 =C2=A0 =C2=A0 "readLock": {}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"count": 0,}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"avgWaitTimeNanos": 0,}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"maxWaitTimeNanos": 0}} > {{=C2=A0 =C2=A0 =C2=A0 },}} > {{=C2=A0 =C2=A0 =C2=A0 "writeLock": {}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"count": 0,}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"avgWaitTimeNanos": 0,}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"maxWaitTimeNanos": 0}} > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } > {{=C2=A0 =C2=A0 },}} > {{=C2=A0 =C2=A0 { "}}{{type": "R/W Lock Stats",}} > {{=C2=A0 =C2=A0 =C2=A0 "label": "QueryTracker",}} > {{=C2=A0 =C2=A0 =C2=A0 "totalLockWaitTimeMillis": 0,}} > {{=C2=A0 =C2=A0 =C2=A0 "readLock": {}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"count": 0,}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"avgWaitTimeNanos": 0,}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"maxWaitTimeNanos": 0}} > {{=C2=A0 =C2=A0 =C2=A0 },}} > {{=C2=A0 =C2=A0 =C2=A0 "writeLock": {}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"count": 0,}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"avgWaitTimeNanos": 0,}} > {{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"maxWaitTimeNanos": 0}} > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } > {{=C2=A0 =C2=A0 }=C2=A0}}{{]}} > {{}}} > To avoid the overhead of lock instrumentation, lock metrics collection is= disabled by default and can be enabled via the following configuration par= ameter: > =C2=A0{{hive.llap.lockmetrics.collect =3D true}} > =C2=A0 > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)