From issues-return-152488-archive-asf-public=cust-asf.ponee.io@hive.apache.org Tue Mar 12 10:58:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 94070180600 for ; Tue, 12 Mar 2019 11:58:03 +0100 (CET) Received: (qmail 10497 invoked by uid 500); 12 Mar 2019 10:58:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 10488 invoked by uid 99); 12 Mar 2019 10:58:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Mar 2019 10:58:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 34462C6702 for ; Tue, 12 Mar 2019 10:58:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -107.499 X-Spam-Level: X-Spam-Status: No, score=-107.499 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_BADIPHTTP=2, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id trbIVUfTLGay for ; Tue, 12 Mar 2019 10:58:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E56766116F for ; Tue, 12 Mar 2019 10:58:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5B7E5E0158 for ; Tue, 12 Mar 2019 10:58:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1579A25811 for ; Tue, 12 Mar 2019 10:58:00 +0000 (UTC) Date: Tue, 12 Mar 2019 10:58:00 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-20580) OrcInputFormat.isOriginal() should not rely on hive.acid.key.index MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790437#comment-16790437 ] Hive QA commented on HIVE-20580: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12962105/HIVE-20580.2.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16464/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16464/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16464/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12962105/HIVE-20580.2.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12962105 - PreCommit-HIVE-Build > OrcInputFormat.isOriginal() should not rely on hive.acid.key.index > ------------------------------------------------------------------ > > Key: HIVE-20580 > URL: https://issues.apache.org/jira/browse/HIVE-20580 > Project: Hive > Issue Type: Improvement > Components: Transactions > Affects Versions: 3.1.0 > Reporter: Eugene Koifman > Assignee: Peter Vary > Priority: Major > Attachments: HIVE-20580.2.patch, HIVE-20580.patch > > > {{org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.isOriginal()}} is checking for presence of {{hive.acid.key.index}} in the footer. This is only created when the file is written by {{OrcRecordUpdater}}. It should instead check for presence of Acid metadata columns so that a file can be produced by something other than {{OrcRecordUpater}}. > Also, {{hive.acid.key.index}} counts number of different type of events which is not really useful for Acid V2 (as of Hive 3) since each file only has 1 type of event. -- This message was sent by Atlassian JIRA (v7.6.3#76005)