hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Bodor (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-21541) Fix missing asf headers from HIVE-15406
Date Sat, 30 Mar 2019 07:18:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805513#comment-16805513
] 

Laszlo Bodor edited comment on HIVE-21541 at 3/30/19 7:17 AM:
--------------------------------------------------------------

thanks [~pvary], [~kgyrtkirk] ! I double-checked, and I found the root cause of duplications...I
copied it from GenericUDFTrunc :)
 [https://github.com/apache/hive/blob/a7a9f516b3803830999f60d2bffb45e76c8a91ef/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java#L2-L3]
so, seems like it's a pattern, which could have spread in the codebase, we should check that...

 

UPDATE: only a few occurences found

{code}
 grep -src Licensed to the Apache Software Foundation . | grep -v ':0$' | grep -v ':1$' |
grep java

./standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/conf/ConfTemplatePrinter.java:2
./common/src/java/org/apache/hadoop/hive/ant/GenHiveTemplate.java:2
./ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java:2
./ql/src/test/org/apache/hadoop/hive/ql/exec/TestOperatorNames.java:2

{code}


was (Author: abstractdog):
thanks [~pvary], [~kgyrtkirk] ! I double-checked, and I found the root cause of duplications...I
copied it from GenericUDFTrunc :)
[https://github.com/apache/hive/blob/a7a9f516b3803830999f60d2bffb45e76c8a91ef/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java#L2-L3]
so, seems like it's a pattern, which could have spread in the codebase, we should check that...

> Fix missing asf headers from HIVE-15406
> ---------------------------------------
>
>                 Key: HIVE-21541
>                 URL: https://issues.apache.org/jira/browse/HIVE-21541
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Laszlo Bodor
>            Assignee: Laszlo Bodor
>            Priority: Major
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21541.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message