hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21368) Vectorization: Unnecessary Decimal64 -> HiveDecimal conversion
Date Mon, 11 Mar 2019 08:46:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789295#comment-16789295
] 

Hive QA commented on HIVE-21368:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12961927/HIVE-21368.1.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 15826 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_1] (batchId=92)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[test_teradatabinaryfile] (batchId=2)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_binary_join_groupby] (batchId=88)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_mapjoin] (batchId=61)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_binary_join_groupby]
(batchId=182)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_mapjoin]
(batchId=174)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_mapjoin3] (batchId=162)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_decimal_mapjoin] (batchId=137)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16439/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16439/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16439/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12961927 - PreCommit-HIVE-Build

> Vectorization: Unnecessary Decimal64 -> HiveDecimal conversion
> --------------------------------------------------------------
>
>                 Key: HIVE-21368
>                 URL: https://issues.apache.org/jira/browse/HIVE-21368
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Gopal V
>            Assignee: Teddy Choi
>            Priority: Major
>         Attachments: HIVE-21368.1.patch
>
>
> Joins projecting Decimal64 have a suspicious cast in the inner loop
> {code}
> ConvertDecimal64ToDecimal(col 14:decimal(7,2)/DECIMAL_64) -> 24:decimal(7,2)'
> {code}
> {code}
> create temporary table foo(x int , y decimal(7,2));
> create temporary table bar(x int , y decimal(7,2));
> set hive.explain.user=false;
> explain vectorization detail select sum(foo.y) from foo, bar where foo.x = bar.x;
> {code}
> {code}
> '                      Map Join Operator'
> '                        condition map:'
> '                             Inner Join 0 to 1'
> '                        keys:'
> '                          0 _col0 (type: int)'
> '                          1 _col0 (type: int)'
> '                        Map Join Vectorization:'
> '                            bigTableKeyColumnNums: [0]'
> '                            bigTableRetainedColumnNums: [3]'
> '                            bigTableValueColumnNums: [3]'
> '                            bigTableValueExpressions: ConvertDecimal64ToDecimal(col
1:decimal(7,2)/DECIMAL_64) -> 3:decimal(7,2)'
> '                            className: VectorMapJoinInnerBigOnlyLongOperator'
> '                            native: true'
> '                            nativeConditionsMet: hive.mapjoin.optimized.hashtable IS
true, hive.vectorized.execution.mapjoin.native.enabled IS true, hive.execution.engine tez
IN [tez, spark] IS true, One MapJoin Condition IS true, No nullsafe IS true, Small table vectorizes
IS true, Fast Hash Table and No Hybrid Hash Join IS true'
> '                            projectedOutputColumnNums: [3]'
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message