hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21264) Improvements Around CharTypeInfo
Date Fri, 08 Mar 2019 02:00:02 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787443#comment-16787443
] 

Hive QA commented on HIVE-21264:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12961600/HIVE-21264.3.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 15822 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_groupby_reduce] (batchId=61)
org.apache.hadoop.hive.ql.TestTxnCommands.testMergeOnTezEdges (batchId=327)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16396/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16396/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16396/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12961600 - PreCommit-HIVE-Build

> Improvements Around CharTypeInfo
> --------------------------------
>
>                 Key: HIVE-21264
>                 URL: https://issues.apache.org/jira/browse/HIVE-21264
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 4.0.0, 3.2.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch, HIVE-21264.3.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and the length
(1-255).  {{CharTypeInfo}} objects are often getting cached once they are created.
> The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are inconsistent.
> * Make hashcode and equals consistent (and fast)
> * Simplify the {{getQualifiedName}} implementation and reduce the scope to protected
> * Other related nits



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message