From issues-return-150343-archive-asf-public=cust-asf.ponee.io@hive.apache.org Fri Feb 22 11:04:23 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9AB8A1807CC for ; Fri, 22 Feb 2019 12:04:21 +0100 (CET) Received: (qmail 60467 invoked by uid 500); 22 Feb 2019 11:04:12 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 60402 invoked by uid 99); 22 Feb 2019 11:04:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Feb 2019 11:04:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EFF92C290B for ; Fri, 22 Feb 2019 11:04:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id NlDNjvk8bSWH for ; Fri, 22 Feb 2019 11:04:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D78FA5F1E3 for ; Fri, 22 Feb 2019 11:04:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 53DBFE280C for ; Fri, 22 Feb 2019 11:04:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 52BD224566 for ; Fri, 22 Feb 2019 11:04:03 +0000 (UTC) Date: Fri, 22 Feb 2019 11:04:03 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HIVE-21292) Break up DDLTask 1 - extract Database related operations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21292?focusedWorklogId=3D= 202545&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpa= nel#worklog-202545 ] ASF GitHub Bot logged work on HIVE-21292: ----------------------------------------- Author: ASF GitHub Bot Created on: 22/Feb/19 11:03 Start Date: 22/Feb/19 11:03 Worklog Time Spent: 10m=20 Work Description: kgyrtkirk commented on pull request #543: HIVE-2129= 2: Break up DDLTask 1 - extract Database related operations URL: https://github.com/apache/hive/pull/543#discussion_r259298189 =20 =20 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer= .java ########## @@ -2571,11 +2567,10 @@ private void analyzeDescDatabase(ASTNode ast) thro= ws SemanticException { throw new SemanticException("Unexpected Tokens at DESCRIBE DATABASE"= ); } =20 - DescDatabaseDesc descDbDesc =3D new DescDatabaseDesc(ctx.getResFile(), - dbName, isExtended); + DescDatabaseDesc descDbDesc =3D new DescDatabaseDesc(ctx.getResFile(),= dbName, isExtended); inputs.add(new ReadEntity(getDatabase(dbName))); - rootTasks.add(TaskFactory.get(new DDLWork(getInputs(), getOutputs(), d= escDbDesc))); - setFetchTask(createFetchTask(descDbDesc.getSchema())); + rootTasks.add(TaskFactory.get(new DDLWork2(getInputs(), getOutputs(), = descDbDesc))); + setFetchTask(createFetchTask(DESC_DATABASE_SCHEMA)); =20 Review comment: I think the `schema` should works similarily to earlier; how about askin= g the DDLWork for the schema? it could look up based on the desc =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 202545) > Break up DDLTask 1 - extract Database related operations > -------------------------------------------------------- > > Key: HIVE-21292 > URL: https://issues.apache.org/jira/browse/HIVE-21292 > Project: Hive > Issue Type: Improvement > Components: Hive > Affects Versions: 3.1.1 > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21292.01.patch, HIVE-21292.02.patch, HIVE-21292= .03.patch, HIVE-21292.04.patch, HIVE-21292.05.patch > > Time Spent: 2h 20m > Remaining Estimate: 0h > > DDLTask is a huge class, more than 5000 lines long. The related DDLWork i= s also a huge class, which has a field for each=C2=A0DDL=C2=A0operation it = supports. The goal is to refactor these in order to have everything cut int= o more handleable classes under the package=C2=A0 org.apache.hadoop.hive.ql= .exec.ddl: > * have a separate class for each operation > * have a package for each operation group (database ddl, table ddl, etc)= , so the amount of classes under a package is more manageable > * make all the requests (DDLDesc subclasses) immutable > * DDLTask should be agnostic to the actual operations > * right now let's ignore the issue of having some operations handled by = DDLTask which are not actual DDL operations (lock, unlock, desc...) > In the interim time when there are two DDLTask and DDLWork classes in the= code base the new ones in the new package are called DDLTask2 and DDLWork2= thus avoiding the usage of fully qualified class names where both the old = and the new classes are in use. > Step #1: extract all the database related operations from the old DDLTask= , and move them under the new package. Also create the new internal framewo= rk. -- This message was sent by Atlassian JIRA (v7.6.3#76005)