hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-21313) Use faster function to prevent copying immutable byte array twice
Date Sun, 24 Feb 2019 07:37:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

ASF GitHub Bot updated HIVE-21313:
----------------------------------
    Labels: pull-request-available  (was: )

> Use faster function to prevent copying immutable byte array twice
> -----------------------------------------------------------------
>
>                 Key: HIVE-21313
>                 URL: https://issues.apache.org/jira/browse/HIVE-21313
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: ZhangXin
>            Priority: Major
>              Labels: pull-request-available
>
> In file ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorAssignRow.java
> We may find code like this:
> ```
> Text text = (Text) convertTargetWritable;
> if (text == null) {
>     text = new Text();
> }
> text.set(string);
> ((BytesColumnVector) columnVector).setVal(
>     batchIndex, text.getBytes(), 0, text.getLength());
> ```
>  
> Using `setVal` method can copy the bytes array generated by `text.getBytes()`. This is
totally unnecessary at all. Since the bytes array is immutable, we can just use `setRef`
method to point to the specific  byte array, which will also lower the memory usage.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message