hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-21292) Break up DDLTask 1 - extract Database related operations
Date Fri, 22 Feb 2019 11:04:03 GMT

     [ https://issues.apache.org/jira/browse/HIVE-21292?focusedWorklogId=202539&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-202539
]

ASF GitHub Bot logged work on HIVE-21292:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Feb/19 11:03
            Start Date: 22/Feb/19 11:03
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on pull request #543: HIVE-21292: Break up DDLTask
1 - extract Database related operations
URL: https://github.com/apache/hive/pull/543#discussion_r259295178
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/ddl/database/ShowDatabasesOperation.java
 ##########
 @@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.exec.ddl.database;
+
+import java.io.DataOutputStream;
+import java.util.List;
+
+import org.apache.hadoop.hive.ql.ErrorMsg;
+import org.apache.hadoop.hive.ql.exec.ddl.DDLOperation;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.io.IOUtils;
+
+/**
+ * Operation process of locking a database.
+ */
+public class ShowDatabasesOperation extends DDLOperation<ShowDatabasesDesc> {
+  @Override
+  public int execute() throws HiveException {
+    // get the databases for the desired pattern - populate the output stream
+    List<String> databases = null;
+    if (ddlDesc.getPattern() != null) {
+      LOG.debug("pattern: {}", ddlDesc.getPattern());
+      databases = db.getDatabasesByPattern(ddlDesc.getPattern());
+    } else {
+      databases = db.getAllDatabases();
+    }
+
+    LOG.info("Found {} database(s) matching the SHOW DATABASES statement.", databases.size());
+
+    // write the results in the file
+    DataOutputStream outStream = getOutputStream(ddlDesc.getResFile());
+    try {
+      formatter.showDatabases(outStream, databases);
 
 Review comment:
   there seems to be a `formatter` for each of these operations; I guess there are less formatter
than operations; but I think the formatters should also "find" a new home
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 202539)
    Time Spent: 1h 40m  (was: 1.5h)

> Break up DDLTask 1 - extract Database related operations
> --------------------------------------------------------
>
>                 Key: HIVE-21292
>                 URL: https://issues.apache.org/jira/browse/HIVE-21292
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>    Affects Versions: 3.1.1
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21292.01.patch, HIVE-21292.02.patch, HIVE-21292.03.patch, HIVE-21292.04.patch,
HIVE-21292.05.patch
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> DDLTask is a huge class, more than 5000 lines long. The related DDLWork is also a huge
class, which has a field for each DDL operation it supports. The goal is to refactor these
in order to have everything cut into more handleable classes under the package  org.apache.hadoop.hive.ql.exec.ddl:
>  * have a separate class for each operation
>  * have a package for each operation group (database ddl, table ddl, etc), so the amount
of classes under a package is more manageable
>  * make all the requests (DDLDesc subclasses) immutable
>  * DDLTask should be agnostic to the actual operations
>  * right now let's ignore the issue of having some operations handled by DDLTask which
are not actual DDL operations (lock, unlock, desc...)
> In the interim time when there are two DDLTask and DDLWork classes in the code base the
new ones in the new package are called DDLTask2 and DDLWork2 thus avoiding the usage of fully
qualified class names where both the old and the new classes are in use.
> Step #1: extract all the database related operations from the old DDLTask, and move them
under the new package. Also create the new internal framework.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message