hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21234) Enforce timestamp range
Date Wed, 27 Feb 2019 18:36:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779620#comment-16779620
] 

Hive QA commented on HIVE-21234:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12960381/HIVE-21234.4.patch

{color:green}SUCCESS:{color} +1 due to 6 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 15819 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_timestamp_funcs] (batchId=33)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_nonvec_part_all_primitive]
(batchId=183)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_nonvec_part_all_primitive_llap_io]
(batchId=183)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_timestamp_funcs]
(batchId=167)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_timestamp_funcs] (batchId=125)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorDateExpressions.testVectorUDFUnixTimeStamp
(batchId=313)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorGenericDateExpressions.testDate
(batchId=314)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorGenericDateExpressions.testToDate
(batchId=314)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16272/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16272/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16272/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12960381 - PreCommit-HIVE-Build

> Enforce timestamp range
> -----------------------
>
>                 Key: HIVE-21234
>                 URL: https://issues.apache.org/jira/browse/HIVE-21234
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>    Affects Versions: 3.1.0
>            Reporter: Karen Coppage
>            Assignee: Karen Coppage
>            Priority: Major
>              Labels: TODOC, backwards-compatibility
>         Attachments: HIVE-21234.1.patch, HIVE-21234.2.patch, HIVE-21234.3.patch, HIVE-21234.4.patch
>
>
> Our Wiki specifies a range for DATE, but not for TIMESTAMP (well, there's a specified
format (yyyy) but no explicitly specified range). [1]
> TIMESTAMP used to have inner representation of java.sql.Timestamp which couldn't handle
timestamps outside of the range of years 0000-9999. (0000 converted to 0001)
> Since the inner representation was changed to LocalDateTime (HIVE-20007), negative timestamps
overflow because of a formatting error.
> I propose simply disabling negative timestamps, and timestamps beyond year 9999. No data
is much better than bad data.
> See [2] for more details.
> [1] https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types#LanguageManualTypes-TimestampstimestampTimestamps
> [2] https://docs.google.com/document/d/1y-GcyzzALXM2AJB3bFuyTAEq5fq6p41gu5eH1pF8I7o/edit?usp=sharing



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message