From issues-return-148234-archive-asf-public=cust-asf.ponee.io@hive.apache.org Thu Jan 31 15:12:07 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8D25E18076D for ; Thu, 31 Jan 2019 16:12:06 +0100 (CET) Received: (qmail 53434 invoked by uid 500); 31 Jan 2019 15:12:05 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 53422 invoked by uid 99); 31 Jan 2019 15:12:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jan 2019 15:12:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3AC86C273B for ; Thu, 31 Jan 2019 15:12:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Y0Lj_4bbmLK4 for ; Thu, 31 Jan 2019 15:12:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 69DC3610E8 for ; Thu, 31 Jan 2019 15:12:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 44A96E26A6 for ; Thu, 31 Jan 2019 15:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 68F5D243C5 for ; Thu, 31 Jan 2019 15:12:00 +0000 (UTC) Date: Thu, 31 Jan 2019 15:12:00 +0000 (UTC) From: "Seung-Hyun Cheong (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-21194) DruidStorageHandler should set a version of segment to UTC MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21194?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Seung-Hyun Cheong updated HIVE-21194: ------------------------------------- Description:=20 h1. Exception while running a KillTask {code:java} 2019-01-30T16:58:35,354 ERROR [task-runner-0-priority-0] io.druid.indexing.= overlord.ThreadPoolTaskRunner - Exception while running task[KillTask{id=3D= kill_upload_2018-12-31T00:00:00.000Z_2019-02-05T00:00:00.000Z_2019-02-01T16= :52:31.851Z, type=3Dkill, dataSource=3Dupload}] io.druid.java.util.common.ISE: WTF?! Unused segment[upload_2019-01-01T00:00= :00.000Z_2019-01-02T00:00:00.000Z_2019-01-31T01:12:32.289+09:00] has versio= n[2019-01-31T01:12:32.289+09:00] > task version[2019-01-30T16:58:29.992Z] =09at io.druid.indexing.common.task.KillTask.run(KillTask.java:94) ~[druid-= indexing-service-0.12.1.3.1.0.0-78.jar:0.12.1.3.1.0.0-78] =09at io.druid.indexing.overlord.ThreadPoolTaskRunner$ThreadPoolTaskRunnerC= allable.call(ThreadPoolTaskRunner.java:444) [druid-indexing-service-0.12.1.= 3.1.0.0-78.jar:0.12.1.3.1.0.0-78] =09at io.druid.indexing.overlord.ThreadPoolTaskRunner$ThreadPoolTaskRunnerC= allable.call(ThreadPoolTaskRunner.java:416) [druid-indexing-service-0.12.1.= 3.1.0.0-78.jar:0.12.1.3.1.0.0-78] =09at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_112= ] =09at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.= java:1142) [?:1.8.0_112] =09at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor= .java:617) [?:1.8.0_112] =09at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112] {code} =C2=A0 h1. Reason h3. [KillTask=C2=A0compares versions|https://github.com/apache/incubator-dr= uid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/co= mmon/task/KillTask.java#L88] {code:java} if (unusedSegment.getVersion().compareTo(myLock.getVersion()) > 0) { throw new ISE( "WTF?! Unused segment[%s] has version[%s] > task version[%s]", unusedSegment.getId(), unusedSegment.getVersion(), myLock.getVersion() ); } {code} =C2=A0 =C2=A0 h3. [KillTask version (UTC, e.g. "2019-01-30T16:58:29.992Z")|https://github= .com/apache/incubator-druid/blob/8eae26fd4e7572060d112864dd3d5f6a865b9c89/i= ndexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbo= x.java#L593] {code:java} version =3D DateTimes.nowUtc().toString(); {code} =C2=A0 =C2=A0 h3. [Segment version (UTC+9, e.g. "2019-01-31T01:12:32.289+09:00")|https://= github.com/apache/hive/blob/master/druid-handler/src/java/org/apache/hadoop= /hive/druid/DruidStorageHandler.java#L755] {code:java} jobProperties.put(DruidConstants.DRUID_SEGMENT_VERSION, new DateTime().toSt= ring()); {code} =C2=A0 =C2=A0 h1. Suggestion h3. Because druid uses UTC only for now, DruidStorageHandler should set a v= ersion of segment to UTC. =C2=A0 =C2=A0 =C2=A0 was: h1. Exception while running a KillTask {code:java} 2019-01-30T16:58:35,354 ERROR [task-runner-0-priority-0] io.druid.indexing.= overlord.ThreadPoolTaskRunner - Exception while running task[KillTask{id=3D= kill_upload_2018-12-31T00:00:00.000Z_2019-02-05T00:00:00.000Z_2019-02-01T16= :52:31.851Z, type=3Dkill, dataSource=3Dupload}] io.druid.java.util.common.ISE: WTF?! Unused segment[upload_2019-01-01T00:00= :00.000Z_2019-01-02T00:00:00.000Z_2019-01-31T01:12:32.289+09:00] has versio= n[2019-01-31T01:12:32.289+09:00] > task version[2019-01-30T16:58:29.992Z] =09at io.druid.indexing.common.task.KillTask.run(KillTask.java:94) ~[druid-= indexing-service-0.12.1.3.1.0.0-78.jar:0.12.1.3.1.0.0-78] =09at io.druid.indexing.overlord.ThreadPoolTaskRunner$ThreadPoolTaskRunnerC= allable.call(ThreadPoolTaskRunner.java:444) [druid-indexing-service-0.12.1.= 3.1.0.0-78.jar:0.12.1.3.1.0.0-78] =09at io.druid.indexing.overlord.ThreadPoolTaskRunner$ThreadPoolTaskRunnerC= allable.call(ThreadPoolTaskRunner.java:416) [druid-indexing-service-0.12.1.= 3.1.0.0-78.jar:0.12.1.3.1.0.0-78] =09at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_112= ] =09at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.= java:1142) [?:1.8.0_112] =09at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor= .java:617) [?:1.8.0_112] =09at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112] {code} =C2=A0 h1. Reason h3. [KillTask=C2=A0compares versions|https://github.com/apache/incubator-dr= uid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/co= mmon/task/KillTask.java#L88] {code:java} if (unusedSegment.getVersion().compareTo(myLock.getVersion()) > 0) { throw new ISE( "WTF?! Unused segment[%s] has version[%s] > task version[%s]", unusedSegment.getId(), unusedSegment.getVersion(), myLock.getVersion() ); } {code} =C2=A0 =C2=A0 h3. [KillTask version (UTC, "{{2019-01-30T16:58:29.992Z}}{{")}}|https://git= hub.com/apache/incubator-druid/blob/8eae26fd4e7572060d112864dd3d5f6a865b9c8= 9/indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLoc= kbox.java#L593] {code:java} version =3D DateTimes.nowUtc().toString(); {code} =C2=A0 =C2=A0 h3. [Segment version (UTC+9, "2019-01-31T01:12:32.289+09:00")|https://githu= b.com/apache/hive/blob/master/druid-handler/src/java/org/apache/hadoop/hive= /druid/DruidStorageHandler.java#L755] {code:java} jobProperties.put(DruidConstants.DRUID_SEGMENT_VERSION, new DateTime().toSt= ring()); {code} =C2=A0 =C2=A0 h1. Suggestion h3. Because druid uses UTC only for now, DruidStorageHandler should set a v= ersion of segment to UTC. =C2=A0 =C2=A0 =C2=A0 > DruidStorageHandler should set a version of segment to UTC > ---------------------------------------------------------- > > Key: HIVE-21194 > URL: https://issues.apache.org/jira/browse/HIVE-21194 > Project: Hive > Issue Type: Bug > Components: Druid integration > Reporter: Seung-Hyun Cheong > Assignee: Seung-Hyun Cheong > Priority: Minor > > h1. Exception while running a KillTask > {code:java} > 2019-01-30T16:58:35,354 ERROR [task-runner-0-priority-0] io.druid.indexin= g.overlord.ThreadPoolTaskRunner - Exception while running task[KillTask{id= =3Dkill_upload_2018-12-31T00:00:00.000Z_2019-02-05T00:00:00.000Z_2019-02-01= T16:52:31.851Z, type=3Dkill, dataSource=3Dupload}] > io.druid.java.util.common.ISE: WTF?! Unused segment[upload_2019-01-01T00:= 00:00.000Z_2019-01-02T00:00:00.000Z_2019-01-31T01:12:32.289+09:00] has vers= ion[2019-01-31T01:12:32.289+09:00] > task version[2019-01-30T16:58:29.992Z] > =09at io.druid.indexing.common.task.KillTask.run(KillTask.java:94) ~[drui= d-indexing-service-0.12.1.3.1.0.0-78.jar:0.12.1.3.1.0.0-78] > =09at io.druid.indexing.overlord.ThreadPoolTaskRunner$ThreadPoolTaskRunne= rCallable.call(ThreadPoolTaskRunner.java:444) [druid-indexing-service-0.12.= 1.3.1.0.0-78.jar:0.12.1.3.1.0.0-78] > =09at io.druid.indexing.overlord.ThreadPoolTaskRunner$ThreadPoolTaskRunne= rCallable.call(ThreadPoolTaskRunner.java:416) [druid-indexing-service-0.12.= 1.3.1.0.0-78.jar:0.12.1.3.1.0.0-78] > =09at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_1= 12] > =09at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecuto= r.java:1142) [?:1.8.0_112] > =09at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecut= or.java:617) [?:1.8.0_112] > =09at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112] > {code} > =C2=A0 > h1. Reason > h3. [KillTask=C2=A0compares versions|https://github.com/apache/incubator-= druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/= common/task/KillTask.java#L88] > {code:java} > if (unusedSegment.getVersion().compareTo(myLock.getVersion()) > 0) { > throw new ISE( > "WTF?! Unused segment[%s] has version[%s] > task version[%s]", > unusedSegment.getId(), > unusedSegment.getVersion(), > myLock.getVersion() > ); > } > {code} > =C2=A0 > =C2=A0 > h3. [KillTask version (UTC, e.g. "2019-01-30T16:58:29.992Z")|https://gith= ub.com/apache/incubator-druid/blob/8eae26fd4e7572060d112864dd3d5f6a865b9c89= /indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLock= box.java#L593] > {code:java} > version =3D DateTimes.nowUtc().toString(); > {code} > =C2=A0 > =C2=A0 > h3. [Segment version (UTC+9, e.g. "2019-01-31T01:12:32.289+09:00")|https:= //github.com/apache/hive/blob/master/druid-handler/src/java/org/apache/hado= op/hive/druid/DruidStorageHandler.java#L755] > {code:java} > jobProperties.put(DruidConstants.DRUID_SEGMENT_VERSION, new DateTime().to= String()); > {code} > =C2=A0 > =C2=A0 > h1. Suggestion > h3. Because druid uses UTC only for now, DruidStorageHandler should set a= version of segment to UTC. > =C2=A0 > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)