hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Vary (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21073) Remove Extra String Object
Date Tue, 01 Jan 2019 15:19:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731620#comment-16731620
] 

Peter Vary commented on HIVE-21073:
-----------------------------------

+1

> Remove Extra String Object
> --------------------------
>
>                 Key: HIVE-21073
>                 URL: https://issues.apache.org/jira/browse/HIVE-21073
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 4.0.0, 3.1.1
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>         Attachments: HIVE-21073.1.patch, HIVE-21073.1.patch
>
>
> {code}
>   public static String generatePath(Path baseURI, String filename) {
>     String path = new String(baseURI + Path.SEPARATOR + filename);
>     return path;
>   }
>   public static String generateFileName(Byte tag, String bigBucketFileName) {
>     String fileName = new String("MapJoin-" + tag + "-" + bigBucketFileName + suffix);
>     return fileName;
>   }
> {code}
> It's a bit odd to be performing string concatenation and then wrapping the results in
a new string.  This is creating superfluous String objects. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message