hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Koifman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20919) Break up UpdateDeleteSemanticAnalyzer
Date Wed, 09 Jan 2019 22:41:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738740#comment-16738740
] 

Eugene Koifman commented on HIVE-20919:
---------------------------------------

+1

> Break up UpdateDeleteSemanticAnalyzer
> -------------------------------------
>
>                 Key: HIVE-20919
>                 URL: https://issues.apache.org/jira/browse/HIVE-20919
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>    Affects Versions: 3.2.0
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>             Fix For: 3.2.0
>
>         Attachments: HIVE-20919.01.patch, HIVE-20919.02.patch, HIVE-20919.03.patch, HIVE-20919.04.patch,
HIVE-20919.05.patch, HIVE-20919.06.patch, HIVE-20919.07.patch
>
>
> UpdateDeleteSemanticAnalyzer handles update, delete, acid export and merge queries by
rewriting them to a different form. This is a clear violation of [SRP|https://en.wikipedia.org/wiki/Single_responsibility_principle],
and therefore needs to be refactored. An abstract ancestor needs to take the common part,
and each of the specific tasks should be handled by a separate class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message