From issues-return-145190-archive-asf-public=cust-asf.ponee.io@hive.apache.org Fri Dec 14 01:27:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 467CE180609 for ; Fri, 14 Dec 2018 01:27:05 +0100 (CET) Received: (qmail 72049 invoked by uid 500); 14 Dec 2018 00:27:04 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 72040 invoked by uid 99); 14 Dec 2018 00:27:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Dec 2018 00:27:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 03C3FC0188 for ; Fri, 14 Dec 2018 00:27:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -107.489 X-Spam-Level: X-Spam-Status: No, score=-107.489 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_BADIPHTTP=2, LOTS_OF_MONEY=0.001, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_MIXED_ES=0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 6zM7w-s_0ZtX for ; Fri, 14 Dec 2018 00:27:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8D887610F5 for ; Fri, 14 Dec 2018 00:27:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9AB2CE00D4 for ; Fri, 14 Dec 2018 00:27:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 57DCA2532D for ; Fri, 14 Dec 2018 00:27:00 +0000 (UTC) Date: Fri, 14 Dec 2018 00:27:00 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-21021) Scalar subquery with only aggregate in subquery (no group by) has unnecessary sq_count_check branch MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720727#comment-16720727 ] Hive QA commented on HIVE-21021: -------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 48s{color} | {color:blue} ql in master has 2310 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 54s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15306/dev-support/hive-personality.sh | | git revision | master / b5b6371 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15306/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Scalar subquery with only aggregate in subquery (no group by) has unnecessary sq_count_check branch > --------------------------------------------------------------------------------------------------- > > Key: HIVE-21021 > URL: https://issues.apache.org/jira/browse/HIVE-21021 > Project: Hive > Issue Type: Improvement > Affects Versions: 3.0.0 > Reporter: Vineet Garg > Assignee: Vineet Garg > Priority: Major > Attachments: HIVE-21021.1.patch, HIVE-21021.2.patch, HIVE-21021.3.patch, HIVE-21021.4.patch, HIVE-21021.5.patch, HIVE-21021.6.patch > > > {code:sql} > CREATE TABLE `store_sales`( > `ss_sold_date_sk` int, > `ss_quantity` int, > `ss_list_price` decimal(7,2)); > CREATE TABLE `date_dim`( > `d_date_sk` int, > `d_year` int); > explain cbo with avg_sales as > (select avg(quantity*list_price) average_sales > from (select ss_quantity quantity > ,ss_list_price list_price > from store_sales > ,date_dim > where ss_sold_date_sk = d_date_sk > and d_year between 1999 and 2001 ) x) > select * from store_sales where ss_list_price > (select average_sales from avg_sales); > {code} > {noformat} > CBO PLAN: > HiveProject(ss_sold_date_sk=[$0], ss_quantity=[$1], ss_list_price=[$2]) > HiveJoin(condition=[true], joinType=[inner], algorithm=[none], cost=[{2.0 rows, 0.0 cpu, 0.0 io}]) > HiveJoin(condition=[>($2, $3)], joinType=[inner], algorithm=[none], cost=[{2.0 rows, 0.0 cpu, 0.0 io}]) > HiveProject(ss_sold_date_sk=[$0], ss_quantity=[$1], ss_list_price=[$2]) > HiveTableScan(table=[[sub, store_sales]], table:alias=[store_sales]) > HiveProject($f0=[/($0, $1)]) > HiveAggregate(group=[{}], agg#0=[sum($0)], agg#1=[count($0)]) > HiveProject($f0=[*(CAST($1):DECIMAL(10, 0), $2)]) > HiveJoin(condition=[=($0, $3)], joinType=[inner], algorithm=[none], cost=[{2.0 rows, 0.0 cpu, 0.0 io}]) > HiveProject(ss_sold_date_sk=[$0], ss_quantity=[$1], ss_list_price=[$2]) > HiveFilter(condition=[IS NOT NULL($0)]) > HiveTableScan(table=[[sub, store_sales]], table:alias=[store_sales]) > HiveProject(d_date_sk=[$0]) > HiveFilter(condition=[AND(BETWEEN(false, $1, 1999, 2001), IS NOT NULL($0))]) > HiveTableScan(table=[[sub, date_dim]], table:alias=[date_dim]) > HiveProject(cnt=[$0]) > HiveFilter(condition=[<=(sq_count_check($0), 1)]) > HiveProject(cnt=[$0]) > HiveAggregate(group=[{}], cnt=[COUNT()]) > HiveProject > HiveProject($f0=[$0]) > HiveAggregate(group=[{}], agg#0=[count($0)]) > HiveJoin(condition=[=($0, $3)], joinType=[inner], algorithm=[none], cost=[{2.0 rows, 0.0 cpu, 0.0 io}]) > HiveProject(ss_sold_date_sk=[$0], ss_quantity=[$1], ss_list_price=[$2]) > HiveFilter(condition=[IS NOT NULL($0)]) > HiveTableScan(table=[[sub, store_sales]], table:alias=[store_sales]) > HiveProject(d_date_sk=[$0]) > HiveFilter(condition=[AND(BETWEEN(false, $1, 1999, 2001), IS NOT NULL($0))]) > HiveTableScan(table=[[sub, date_dim]], table:alias=[date_dim]) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)