From issues-return-144556-archive-asf-public=cust-asf.ponee.io@hive.apache.org Fri Dec 7 16:19:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9090018067A for ; Fri, 7 Dec 2018 16:19:08 +0100 (CET) Received: (qmail 36717 invoked by uid 500); 7 Dec 2018 15:19:07 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 36592 invoked by uid 99); 7 Dec 2018 15:19:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2018 15:19:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 26BB1C1E24 for ; Fri, 7 Dec 2018 15:19:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.3 X-Spam-Level: X-Spam-Status: No, score=-108.3 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_BADIPHTTP=2, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id DfM5if8rKQcZ for ; Fri, 7 Dec 2018 15:19:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5119160CFD for ; Fri, 7 Dec 2018 14:43:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 87F20E00EA for ; Fri, 7 Dec 2018 14:43:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 49AE3252C6 for ; Fri, 7 Dec 2018 14:43:00 +0000 (UTC) Date: Fri, 7 Dec 2018 14:43:00 +0000 (UTC) From: "Hive QA (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-20961) Retire NVL implementation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712931#comment-16712931 ] Hive QA commented on HIVE-20961: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12950964/HIVE-20961.02.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 15650 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_predicate_pushdown] (batchId=262) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constantPropWhen] (batchId=37) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fold_case] (batchId=16) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fold_when] (batchId=30) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_memcheck] (batchId=45) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_ppd_key_range] (batchId=103) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_pushdown] (batchId=103) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_limit] (batchId=182) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15210/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15210/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15210/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 8 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12950964 - PreCommit-HIVE-Build > Retire NVL implementation > ------------------------- > > Key: HIVE-20961 > URL: https://issues.apache.org/jira/browse/HIVE-20961 > Project: Hive > Issue Type: Improvement > Reporter: Zoltan Haindrich > Assignee: Laszlo Bodor > Priority: Major > Attachments: HIVE-20961.01.patch, HIVE-20961.02.patch > > > Right now we have coalesce and nvl implemented separetly; it might be better to remove one of them as they are doing the same. Because Coalesce is in the standard - I think NVL have to go...and became an alias to Coalesce. > Further benefit is: that optimizations which coalesce already recieves; will be done on NVL calls as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)