hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21073) Remove Extra String Object
Date Thu, 27 Dec 2018 20:28:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729851#comment-16729851
] 

Hive QA commented on HIVE-21073:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12953169/HIVE-21073.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 15759 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15442/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15442/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15442/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12953169 - PreCommit-HIVE-Build

> Remove Extra String Object
> --------------------------
>
>                 Key: HIVE-21073
>                 URL: https://issues.apache.org/jira/browse/HIVE-21073
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 4.0.0, 3.1.1
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>         Attachments: HIVE-21073.1.patch, HIVE-21073.1.patch
>
>
> {code}
>   public static String generatePath(Path baseURI, String filename) {
>     String path = new String(baseURI + Path.SEPARATOR + filename);
>     return path;
>   }
>   public static String generateFileName(Byte tag, String bigBucketFileName) {
>     String fileName = new String("MapJoin-" + tag + "-" + bigBucketFileName + suffix);
>     return fileName;
>   }
> {code}
> It's a bit odd to be performing string concatenation and then wrapping the results in
a new string.  This is creating superfluous String objects. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message