hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sankar Hariappan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-20989) JDBC - The GetOperationStatus + log can block query progress via sleep()
Date Thu, 20 Dec 2018 08:51:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-20989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sankar Hariappan updated HIVE-20989:
------------------------------------
    Status: Patch Available  (was: Open)

> JDBC - The GetOperationStatus + log can block query progress via sleep()
> ------------------------------------------------------------------------
>
>                 Key: HIVE-20989
>                 URL: https://issues.apache.org/jira/browse/HIVE-20989
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>    Affects Versions: 4.0.0
>            Reporter: Gopal V
>            Assignee: Sankar Hariappan
>            Priority: Major
>         Attachments: HIVE-20989.01.patch
>
>
> There is an exponential sleep operation inside the CLIService which can end up adding
tens of seconds to a query which has already completed.
> {code}
> "HiveServer2-Handler-Pool: Thread-9373" #9373 prio=5 os_prio=0 tid=0x00007f4d5e72d800
nid=0xb634a waiting on condition [0x00007f28d06a5000]
> java.lang.Thread.State: TIMED_WAITING (sleeping)
> at java.lang.Thread.sleep(Native Method)
> at org.apache.hive.service.cli.CLIService.progressUpdateLog(CLIService.java:506)
> at org.apache.hive.service.cli.CLIService.getOperationStatus(CLIService.java:480)
> at org.apache.hive.service.cli.thrift.ThriftCLIService.GetOperationStatus(ThriftCLIService.java:695)
> at org.apache.hive.service.rpc.thrift.TCLIService$Processor$GetOperationStatus.getResult(TCLIService.java:1757)
> at org.apache.hive.service.rpc.thrift.TCLIService$Processor$GetOperationStatus.getResult(TCLIService.java:1742)
> at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39)
> at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39)
> at org.apache.hive.service.auth.TSetIpAddressProcessor.process(TSetIpAddressProcessor.java:56)
> at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:286)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> The sleep loop is on the server side.
> {code}
> private static final long PROGRESS_MAX_WAIT_NS = 30 * 1000000000l;
> private JobProgressUpdate progressUpdateLog(boolean isProgressLogRequested, Operation
operation, HiveConf conf) {
> ...
>     long startTime = System.nanoTime();
>     int timeOutMs = 8;
>     try {
>       while (sessionState.getProgressMonitor() == null && !operation.isDone())
{
>         long remainingMs = (PROGRESS_MAX_WAIT_NS - (System.nanoTime() - startTime)) /
1000000l;
>         if (remainingMs <= 0) {
>           LOG.debug("timed out and hence returning progress log as NULL");
>           return new JobProgressUpdate(ProgressMonitor.NULL);
>         }
>         Thread.sleep(Math.min(remainingMs, timeOutMs));
>         timeOutMs <<= 1;
>       }
> {code}
> After about 16 seconds of execution of the query, the timeOutMs is 16384 ms, which means
the next sleep cycle is for min(30 - 17, 16) = 13.
> If the query finishes on the 17th second, the JDBC server will only respond after the
30th second when it will check for operation.isDone() and return.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message