hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20896) CachedStore fail to cache stats in multiple code paths
Date Fri, 14 Dec 2018 06:18:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720979#comment-16720979
] 

Hive QA commented on HIVE-20896:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 57s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 24s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m  7s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m  4s{color} | {color:blue}
standalone-metastore/metastore-server in master has 188 extant Findbugs warnings. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 17s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 27s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 23s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 23s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m  7s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 10s{color} | {color:red}
standalone-metastore/metastore-server generated 1 new + 188 unchanged - 0 fixed = 189 total
(was 188) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 17s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 12s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 46s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
|  |  Dead store to partitionColStats in org.apache.hadoop.hive.metastore.cache.CachedStore$CacheUpdateMasterWork.updateTablePartitionColStats(RawStore,
String, String, String)  At CachedStore.java:org.apache.hadoop.hive.metastore.cache.CachedStore$CacheUpdateMasterWork.updateTablePartitionColStats(RawStore,
String, String, String)  At CachedStore.java:[line 602] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15316/dev-support/hive-personality.sh
|
| git revision | master / e8e0396 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-15316/yetus/new-findbugs-standalone-metastore_metastore-server.html
|
| modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server
|
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15316/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> CachedStore fail to cache stats in multiple code paths
> ------------------------------------------------------
>
>                 Key: HIVE-20896
>                 URL: https://issues.apache.org/jira/browse/HIVE-20896
>             Project: Hive
>          Issue Type: Bug
>          Components: Standalone Metastore
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>            Priority: Major
>         Attachments: HIVE-20896.0.patch, HIVE-20896.1.patch, HIVE-20896.2.patch, HIVE-20896.3.patch,
HIVE-20896.4.patch, HIVE-20896.5.patch, HIVE-20896.6.patch
>
>
> Bunch of issues discovered in CachedStore to keep up column statistics:
> 1. The criteria for partition/non-partition is wrong (table.isSetPartitionKeys() is
always true)
> 2. In update(), partition column stats are removed when populate table basic stats
> 3. Dirty flags are true right after prewarm(), so the first update() does not do anything
> 4. Could invoke cacheLock without holding the lock, which results a freeze in update()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message