hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20159) Do Not Print StackTraces to STDERR in ConditionalResolverSkewJoin
Date Tue, 25 Dec 2018 05:20:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728591#comment-16728591
] 

Hive QA commented on HIVE-20159:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12953006/HIVE.20159.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 15759 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15431/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15431/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15431/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12953006 - PreCommit-HIVE-Build

> Do Not Print StackTraces to STDERR in ConditionalResolverSkewJoin
> -----------------------------------------------------------------
>
>                 Key: HIVE-20159
>                 URL: https://issues.apache.org/jira/browse/HIVE-20159
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Planning
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: Mani M
>            Priority: Minor
>              Labels: newbie, noob
>         Attachments: HIVE.20159.patch
>
>
> https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverSkewJoin.java#L121
> {code}
>     } catch (IOException e) {
>       e.printStackTrace();
>     }
> {code}
> Introduce an SLF4J logger to this class and print a WARN level log message if the {{IOException}}
from {{Utilities.listStatusIfExists}} is generated.  I suggest WARN because the entire operation
doesn't fail if this error happens.  It continues on its way with the data that it was able
to collect.  I'm not sure if this is the intended behavior, but for now, a helpful warning
message in the logging would be better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message