hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-16976) DPP: SyntheticJoinPredicate transitivity for < > and BETWEEN
Date Sat, 22 Dec 2018 02:16:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-16976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727176#comment-16727176
] 

Hive QA commented on HIVE-16976:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 56s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 59s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 37s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 43s{color} | {color:blue}
ql in master has 2309 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 53s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 24s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 59s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 59s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 38s{color} | {color:red}
ql: The patch generated 22 new + 58 unchanged - 3 fixed = 80 total (was 61) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 10s{color} | {color:red}
ql generated 1 new + 2309 unchanged - 0 fixed = 2310 total (was 2309) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 54s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 13s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 55s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Possible null pointer dereference of table in org.apache.hadoop.hive.ql.optimizer.DynamicPartitionPruningOptimization.process(Node,
Stack, NodeProcessorCtx, Object[])  Dereferenced at DynamicPartitionPruningOptimization.java:table
in org.apache.hadoop.hive.ql.optimizer.DynamicPartitionPruningOptimization.process(Node, Stack,
NodeProcessorCtx, Object[])  Dereferenced at DynamicPartitionPruningOptimization.java:[line
192] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15426/dev-support/hive-personality.sh
|
| git revision | master / 49f8f84 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-15426/yetus/diff-checkstyle-ql.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-15426/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15426/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> DPP: SyntheticJoinPredicate transitivity for < > and BETWEEN
> ------------------------------------------------------------
>
>                 Key: HIVE-16976
>                 URL: https://issues.apache.org/jira/browse/HIVE-16976
>             Project: Hive
>          Issue Type: Improvement
>          Components: Tez
>    Affects Versions: 2.1.1, 3.0.0
>            Reporter: Gopal V
>            Assignee: Deepak Jaiswal
>            Priority: Major
>         Attachments: HIVE-16976.1.patch, HIVE-16976.2.patch
>
>
> Tez DPP does not kick in for scenarios where a user wants to run a comparison clause
instead of a JOIN/IN clause.
> {code}
> explain select count(1) from store_sales where ss_sold_date_sk > (select max(d_Date_sk)
from date_dim where d_year = 2017);
> Warning: Map Join MAPJOIN[21][bigTable=?] in task 'Map 1' is a cross product
> OK
> Plan optimized by CBO.
> Vertex dependency in root stage
> Map 1 <- Reducer 4 (BROADCAST_EDGE)
> Reducer 2 <- Map 1 (CUSTOM_SIMPLE_EDGE)
> Reducer 4 <- Map 3 (CUSTOM_SIMPLE_EDGE)
> Stage-0
>   Fetch Operator
>     limit:-1
>     Stage-1
>       Reducer 2 vectorized, llap
>       File Output Operator [FS_36]
>         Group By Operator [GBY_35] (rows=1 width=8)
>           Output:["_col0"],aggregations:["count(VALUE._col0)"]
>         <-Map 1 [CUSTOM_SIMPLE_EDGE] vectorized, llap
>           PARTITION_ONLY_SHUFFLE [RS_34]
>             Group By Operator [GBY_33] (rows=1 width=8)
>               Output:["_col0"],aggregations:["count(1)"]
>               Select Operator [SEL_32] (rows=9600142089 width=16)
>                 Filter Operator [FIL_31] (rows=9600142089 width=16)
>                   predicate:(_col0 > _col1)
>                   Map Join Operator [MAPJOIN_30] (rows=28800426268 width=16)
>                     Conds:(Inner),Output:["_col0","_col1"]
>                   <-Reducer 4 [BROADCAST_EDGE] vectorized, llap
>                     BROADCAST [RS_28]
>                       Group By Operator [GBY_27] (rows=1 width=8)
>                         Output:["_col0"],aggregations:["max(VALUE._col0)"]
>                       <-Map 3 [CUSTOM_SIMPLE_EDGE] vectorized, llap
>                         PARTITION_ONLY_SHUFFLE [RS_26]
>                           Group By Operator [GBY_25] (rows=1 width=8)
>                             Output:["_col0"],aggregations:["max(d_date_sk)"]
>                             Select Operator [SEL_24] (rows=652 width=12)
>                               Output:["d_date_sk"]
>                               Filter Operator [FIL_23] (rows=652 width=12)
>                                 predicate:(d_year = 2017)
>                                 TableScan [TS_2] (rows=73049 width=12)
>                                   tpcds_bin_partitioned_newschema_orc_10000@date_dim,date_dim,Tbl:COMPLETE,Col:COMPLETE,Output:["d_date_sk","d_year"]
>                   <-Select Operator [SEL_29] (rows=28800426268 width=8)
>                       Output:["_col0"]
>                       TableScan [TS_0] (rows=28800426268 width=172)
>                         tpcds_bin_partitioned_newschema_orc_10000@store_sales,store_sales,Tbl:COMPLETE,Col:COMPLETE
> {code}
> The SyntheticJoinPredicate is only injected for equi joins, not for < or > scalar
subqueries.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message