From issues-return-144056-archive-asf-public=cust-asf.ponee.io@hive.apache.org Fri Nov 30 16:33:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4774F180677 for ; Fri, 30 Nov 2018 16:33:03 +0100 (CET) Received: (qmail 96067 invoked by uid 500); 30 Nov 2018 15:33:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 96027 invoked by uid 99); 30 Nov 2018 15:33:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Nov 2018 15:33:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 01B70C610C for ; Fri, 30 Nov 2018 15:33:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id VplfqlJIB5a7 for ; Fri, 30 Nov 2018 15:33:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CC9A260F5C for ; Fri, 30 Nov 2018 15:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6FFB9E0177 for ; Fri, 30 Nov 2018 15:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 357DC24DD3 for ; Fri, 30 Nov 2018 15:33:00 +0000 (UTC) Date: Fri, 30 Nov 2018 15:33:00 +0000 (UTC) From: "BELUGA BEHR (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-20255) Review LevelOrderWalker.java MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-20255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HIVE-20255: ------------------------------- Status: Open (was: Patch Available) > Review LevelOrderWalker.java > ---------------------------- > > Key: HIVE-20255 > URL: https://issues.apache.org/jira/browse/HIVE-20255 > Project: Hive > Issue Type: Improvement > Components: Query Planning > Affects Versions: 3.0.0, 4.0.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Minor > Attachments: HIVE-20255.1.patch, HIVE-20255.2.patch, HIVE-20255.3.patch, HIVE-20255.4.patch, HIVE-20255.5.patch > > > https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/lib/LevelOrderWalker.java > * Make code more concise > * Fix some check style issues > {code} > if (toWalk.get(index).getChildren() != null) { > for(Node child : toWalk.get(index).getChildren()) { > {code} > Actually, the underlying implementation of {{getChildren()}} has to do some real work, so do not throw away the work after checking for null. Simply call once and store the results. -- This message was sent by Atlassian JIRA (v7.6.3#76005)