hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20940) Bridge cases in which Calcite's type resolution is more stricter than Hive.
Date Tue, 20 Nov 2018 15:49:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693395#comment-16693395
] 

Hive QA commented on HIVE-20940:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 44s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  1s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 36s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 41s{color} | {color:blue}
ql in master has 2317 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 56s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 22s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  1s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  1s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 37s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 53s{color} | {color:red}
ql generated 1 new + 2317 unchanged - 0 fixed = 2318 total (was 2317) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 55s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 13s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 27s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Check for oddness that won't work for negative numbers in org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
RelDataType)  At RexNodeConverter.java:work for negative numbers in org.apache.hadoop.hive.ql.optimizer.calcite.translator.RexNodeConverter.adjustCaseBranchTypes(List,
RelDataType)  At RexNodeConverter.java:[line 497] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15011/dev-support/hive-personality.sh
|
| git revision | master / 1fe471d |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-15011/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15011/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Bridge cases in which Calcite's type resolution is more stricter than Hive.
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-20940
>                 URL: https://issues.apache.org/jira/browse/HIVE-20940
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>         Attachments: HIVE-20940.01.patch, HIVE-20940.01.patch, HIVE-20940.02.patch, HIVE-20940.03.patch,
HIVE-20940.04.patch, HIVE-20940.04.patch
>
>
> Calcite is more stricter w.r.t common types than Hive.
> For example in case a CASE with different types on the branches is not something Calcite
likes:
> {code}
> CASE
>   WHEN cond1 THEN booleanCol
>   WHEN cond2 THEN stringCol
>   WHEN cond3 THEN floatCol
>   ELSE doubleCol
> END
> {code}
> issues will only happen with 1.18-SNAPSHOT version



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message