hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20853) Expose ShuffleHandler.registerDag in the llap daemon API
Date Thu, 08 Nov 2018 08:00:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679396#comment-16679396
] 

Hive QA commented on HIVE-20853:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 30s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 10s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  0s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 40s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 26s{color} | {color:blue}
llap-common in master has 71 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 23s{color} | {color:blue}
llap-client in master has 26 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 22s{color} | {color:blue}
llap-tez in master has 17 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 36s{color} | {color:blue}
llap-server in master has 83 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 46s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  9s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 16s{color} | {color:red}
llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 16s{color} | {color:red}
llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 16s{color} | {color:red}
llap-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m  8s{color}
| {color:green} The patch llap-common passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m  9s{color}
| {color:green} The patch llap-client passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 10s{color}
| {color:green} llap-tez: The patch generated 0 new + 113 unchanged - 7 fixed = 113 total
(was 120) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 13s{color} | {color:red}
llap-server: The patch generated 6 new + 156 unchanged - 1 fixed = 162 total (was 157) {color}
|
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 36s{color} | {color:red}
llap-common generated 5 new + 71 unchanged - 0 fixed = 76 total (was 71) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 16s{color} | {color:red}
llap-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 45s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 12s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 18m 21s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:llap-common |
|  |  org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$RegisterDagRequestProto.PARSER
isn't final but should be  At LlapDaemonProtocolProtos.java:be  At LlapDaemonProtocolProtos.java:[line
11608] |
|  |  Class org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$RegisterDagRequestProto
defines non-transient non-serializable instance field unknownFields  In LlapDaemonProtocolProtos.java:instance
field unknownFields  In LlapDaemonProtocolProtos.java |
|  |  org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$RegisterDagResponseProto.PARSER
isn't final but should be  At LlapDaemonProtocolProtos.java:be  At LlapDaemonProtocolProtos.java:[line
12356] |
|  |  Class org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$RegisterDagResponseProto
defines non-transient non-serializable instance field unknownFields  In LlapDaemonProtocolProtos.java:instance
field unknownFields  In LlapDaemonProtocolProtos.java |
|  |  Useless control flow in org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos$RegisterDagResponseProto$Builder.maybeForceBuilderInitialization()
 At LlapDaemonProtocolProtos.java: At LlapDaemonProtocolProtos.java:[line 12530] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14805/dev-support/hive-personality.sh
|
| git revision | master / 840dd43 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-14805/yetus/patch-mvninstall-llap-server.txt
|
| compile | http://104.198.109.242/logs//PreCommit-HIVE-Build-14805/yetus/patch-compile-llap-server.txt
|
| javac | http://104.198.109.242/logs//PreCommit-HIVE-Build-14805/yetus/patch-compile-llap-server.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14805/yetus/diff-checkstyle-llap-server.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-14805/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-14805/yetus/new-findbugs-llap-common.html
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-14805/yetus/patch-findbugs-llap-server.txt
|
| modules | C: llap-common llap-client llap-tez llap-server U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14805/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Expose ShuffleHandler.registerDag in the llap daemon API
> --------------------------------------------------------
>
>                 Key: HIVE-20853
>                 URL: https://issues.apache.org/jira/browse/HIVE-20853
>             Project: Hive
>          Issue Type: Improvement
>          Components: llap
>    Affects Versions: 3.1.0
>            Reporter: Jaume M
>            Assignee: Jaume M
>            Priority: Critical
>         Attachments: HIVE-20853.1.patch, HIVE-20853.2.patch, HIVE-20853.3.patch, HIVE-20853.4.patch,
HIVE-20853.5.patch
>
>
> Currently DAGs are only registered when a submitWork is called for that DAG. At this
point the crendentials are added to the ShuffleHandler and it can start serving.
> However Tez might (and will) schedule tasks to fetch from the ShuffleHandler before anything
of this happens and all this tasks will fail which may results in the query failing.
> This happens in the scenario in which a LlapDaemon just comes up and tez fetchers try
to open a connection before a DAG has been registered.
> Adding this API will allow to register the DAG against the Daemon when the AM notices
that a new Daemon is up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message