hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20823) Make Compactor run in a transaction
Date Tue, 13 Nov 2018 08:09:01 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684845#comment-16684845
] 

Hive QA commented on HIVE-20823:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12947931/HIVE-20823.11.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14904/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14904/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14904/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12947931/HIVE-20823.11.patch
was found in seen patch url's cache and a test was probably run already on it. Aborting...
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12947931 - PreCommit-HIVE-Build

> Make Compactor run in a transaction
> -----------------------------------
>
>                 Key: HIVE-20823
>                 URL: https://issues.apache.org/jira/browse/HIVE-20823
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>            Priority: Major
>         Attachments: HIVE-20823.01.patch, HIVE-20823.03.patch, HIVE-20823.04.patch, HIVE-20823.05.patch,
HIVE-20823.07.patch, HIVE-20823.08.patch, HIVE-20823.09.patch, HIVE-20823.10.patch, HIVE-20823.11.patch,
HIVE-20823.11.patch
>
>
> Have compactor open a transaction and run the job in that transaction.
> # make compactor produced base/delta include this txn id in the folder name, e.g. base_7_c17
where 17 is the txnid.
> # add {{CQ_TXN_ID bigint}} to COMPACTION_QUEUE and COMPLETED_COMPACTIONS to record this
txn id
> # make sure {{AcidUtils.getAcidState()}} pays attention to this transaction on read and
ignores this dir if this txn id is not committed in the current snapshot
> ## this means not only validWriteIdList but ValidTxnIdList should be passed along in
config (if it isn't yet)
> # once this is done, {{CompactorMR.createCompactorMarker()}} can be eliminated and {{AcidUtils.isValidBase}}
modified accordingly
> # modify Cleaner so that it doesn't clean old files until new file is visible to all
readers
> # 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message