hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-20847) Review of NullScanCode
Date Wed, 31 Oct 2018 18:51:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-20847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

BELUGA BEHR updated HIVE-20847:
-------------------------------
    Status: Patch Available  (was: Open)

> Review of NullScanCode
> ----------------------
>
>                 Key: HIVE-20847
>                 URL: https://issues.apache.org/jira/browse/HIVE-20847
>             Project: Hive
>          Issue Type: Improvement
>          Components: Physical Optimizer
>    Affects Versions: 3.1.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HIVE-20847.1.patch
>
>
> What got me looking at this class was the verboseness of some of the logging.  I would
like to request that we DEBUG the logging since this level of detail means nothing to a cluster
admin.
> Also... this {{contains}} call would be better applied onto a {{HashSet}} instead of
an {{ArrayList}}.
> {code:java|title=NullScanTaskDispatcher.java}
>   private void processAlias(MapWork work, Path path, ArrayList<String> aliasesAffected,
ArrayList<String> aliases) {
>     // the aliases that are allowed to map to a null scan.
>     ArrayList<String> allowed = new ArrayList<String>();
>     for (String alias : aliasesAffected) {
>       if (aliases.contains(alias)) {
>         allowed.add(alias);
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message