hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharathkrishna Guruvayoor Murali (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-20698) Better error instead of NPE when timestamp is null for any row when ingesting to druid
Date Fri, 05 Oct 2018 22:03:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-20698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640393#comment-16640393
] 

Bharathkrishna Guruvayoor Murali commented on HIVE-20698:
---------------------------------------------------------

LGTM.
Just nit: 
{code:java}
Preconditions.checkNotNull(timestamp,"Timestamp column cannot have null value");{code}
Needs space after ,

> Better error instead of NPE when timestamp is null for any row when ingesting to druid
> --------------------------------------------------------------------------------------
>
>                 Key: HIVE-20698
>                 URL: https://issues.apache.org/jira/browse/HIVE-20698
>             Project: Hive
>          Issue Type: Improvement
>          Components: Druid integration
>            Reporter: Nishant Bangarwa
>            Assignee: Nishant Bangarwa
>            Priority: Major
>         Attachments: HIVE-20698.patch
>
>
> Currently when ingesting data to druid we get a wierd NPE when timestamp is null for
any row. 
> We should provide an error with a better message which helps user to know what is actually
wrong. 
> {code} 
> Caused by: java.lang.NullPointerException
>   at org.apache.hadoop.hive.druid.serde.DruidSerDe.serialize(DruidSerDe.java:364)
>   at org.apache.hadoop.hive.ql.exec.FileSinkOperator.process(FileSinkOperator.java:957)
>   at org.apache.hadoop.hive.ql.exec.vector.VectorFileSinkOperator.process(VectorFileSinkOperator.java:111)
>   at org.apache.hadoop.hive.ql.exec.Operator.vectorForward(Operator.java:965)
>   at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:938)
>   at org.apache.hadoop.hive.ql.exec.vector.VectorSelectOperator.process(VectorSelectOperator.java:158)
>   at org.apache.hadoop.hive.ql.exec.tez.ReduceRecordSource.processVectorGroup(ReduceRecordSource.java:480)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message