hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Bapat (JIRA)" <>
Subject [jira] [Updated] (HIVE-20542) Incremental REPL DUMP progress information log message is incorrect.
Date Thu, 11 Oct 2018 05:50:00 GMT


Ashutosh Bapat updated HIVE-20542:
    Attachment: HIVE-20542.02
        Status: Patch Available  (was: In Progress)

[~sankarh], PFA patch with your comments addressed. See some replies to you comments below
(Your comments marked as SHC)
 # SHC: Need to use Java naming conventions for variables. Eg, dbname_val should be dbNameVal
 ## Done.
 # SHC: In addNotificationLoag method, seen similar issue where table name is set to " " (with
single space) if it is not an input. Can we make it null if not available.
 ## Done.
 # SHC: addNotificationLog can use event.getCatName()  to set catalogue name instead of always
setting it to NULL.
 ## Done.
 # SHC: getNotificationEventsCount can take an optional toEventId as it is allowed for incremental
replication. Also, check if we can include LIMIT as well.
 ## Done.
 # SHC: In  getNotificationEventsCount, can we use (dbName IS NULL) instead of (dbName ==
null)? Same with catalogName too.
 ## No, JDOQL doesn't understand IS NULL construct.
 # SHC: Can add a unit test in to verify if getNotificationEventsCount
return proper count for events with db name and not. Shall add a modifier method for getNotificationEventsCount
in InjectableBehaviourObjectStore and in the modifier just check if you receive proper count
with different inputs for fromEventId, toEventId and limit.
 ## Done in a different way. I invoked getNotificationEventsCount method directly of Metastore
Client with different combinations of arguments. Also added a testcase to make sure that OPEN/COMMIT
TRANSACTION events are counted correctly.

> Incremental REPL DUMP progress information log message is incorrect.
> --------------------------------------------------------------------
>                 Key: HIVE-20542
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: repl
>    Affects Versions: 4.0.0, 3.2.0
>            Reporter: Sankar Hariappan
>            Assignee: Ashutosh Bapat
>            Priority: Minor
>              Labels: DR, Replication, pull-request-available
>         Attachments: HIVE-20542.01.patch, HIVE-20542.02
> Incremental REPL DUMP have the progress information logged as "eventsDumpProgress":"49/0".
> It should actually log the estimated number of events are denominator but it is coming
as 0 always.

This message was sent by Atlassian JIRA

View raw message